Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID3v2TagReader _getFrameData #64

Closed
ghost opened this issue Jul 24, 2017 · 1 comment
Closed

ID3v2TagReader _getFrameData #64

ghost opened this issue Jul 24, 2017 · 1 comment
Assignees
@aadsm

Comments

@ghost
Copy link

ghost commented Jul 24, 2017

It should be:

(frames[id] instanceof Array ? frames[id][0] : frames[id]).data

not

frames[id].data
@ghost
Copy link
Author

ghost commented Jul 30, 2017 •
edited by ghost
Loading

You should do that. Because sometimes when a song file has 2 comments or 2 something. comment prop shortcut would be undefined.

This doesn't just apply to comment. It does apply to all shortcuts.

@aadsm aadsm self-assigned this Aug 6, 2017
@aadsm aadsm closed this as completed in 80ed3b8 Aug 6, 2017
aadsm added a commit that referenced this issue Aug 6, 2017
@aadsm
Version 3.7.0
bc85b6a 
- Fix ID3 chapter bugs and tests
- Workaround for undeclared padding (#69)
- Add UFID support for ID3 tags
- Check for ArrayBuffer.isView for older versions of Firefox (#51)
- Fix shortcuts for frame ids with multiple entries (#64)
- Use native XHR in WebWorker environment (#65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadsm aadsm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aadsm