Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset <..> hasn't been loaded yet. #69

Closed
pioug opened this issue Jul 29, 2017 · 4 comments
Closed

Offset <..> hasn't been loaded yet. #69

pioug opened this issue Jul 29, 2017 · 4 comments
Assignees

Comments

@pioug
Copy link
Contributor

pioug commented Jul 29, 2017

{ type: 'parseData',
  info: 'Offset 70666 hasn\'t been loaded yet.' }

I am facing this issue with few files. I am using 3.6.2. I pushed a test case here: https://github.com/aadsm/jsmediatags/compare/master...pioug:issue?expand=1.

I saw that you fixed similar errors recently with different solutions (#58, #49). So I am better asking you first before digging in the code 🤔

@aadsm aadsm self-assigned this Jul 29, 2017
@aadsm
Copy link
Owner

aadsm commented Jul 30, 2017

@pioug, the link you provide doesn't point me to the test case, can you update it so I can have access to the music file and fix the issue?

@pioug
Copy link
Contributor Author

pioug commented Jul 30, 2017

I just realized that the parsing works well in the browser but not in Node. It may be easier to solve than I thought.

What is the best solution to provide you a test case for Node? So far, I forked your project https://github.com/pioug/jsmediatags/tree/master and added the test files in /issue. You can run the script via node issue/.

Link to browser version: https://pioug.github.io/jsmediatags/issue/index.html.

Thanks a lot for the weekend support! I will check the build pipeline to see if we can add the source maps somewhere.

Update:

@aadsm
Copy link
Owner

aadsm commented Aug 5, 2017

This is an interesting case, it looks like cry.mp3 has a 2 byte padding at the end of the tag but it doesn't have an extended header declaring padding size.
I'll add a sanity check to detect this issue.

@aadsm aadsm closed this as completed in 752fd52 Aug 6, 2017
aadsm added a commit that referenced this issue Aug 6, 2017
- Fix ID3 chapter bugs and tests
- Workaround for undeclared padding (#69)
- Add UFID support for ID3 tags
- Check for ArrayBuffer.isView for older versions of Firefox (#51)
- Fix shortcuts for frame ids with multiple entries (#64)
- Use native XHR in WebWorker environment (#65)
@pioug
Copy link
Contributor Author

pioug commented Aug 14, 2017

Awesome support! It works perfectly now. jsmediatags parses my +30 GB library without flinching 😛 Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants