Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_createXHRObject Error in Web Worker #65

Closed
ghost opened this issue Jul 24, 2017 · 1 comment
Closed

_createXHRObject Error in Web Worker #65

ghost opened this issue Jul 24, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 24, 2017

_createXHRObject Error in Web Worker

Can be simply fixed:

function _createXHRObject() {
return new XMLHttpRequest();
};

But this would disable node XHR2

@ghost
Copy link
Author

ghost commented Jul 24, 2017

And if you want to require XHR2, then this is the right way:

var NXMLHttpRequest = require('xhr2');
var xhr = new NXMLHttpRequest();

return xhr;

@aadsm aadsm closed this as completed in 9e89883 Aug 6, 2017
aadsm added a commit that referenced this issue Aug 6, 2017
- Fix ID3 chapter bugs and tests
- Workaround for undeclared padding (#69)
- Add UFID support for ID3 tags
- Check for ArrayBuffer.isView for older versions of Firefox (#51)
- Fix shortcuts for frame ids with multiple entries (#64)
- Use native XHR in WebWorker environment (#65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants