-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Improve Section component (former Category) #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formerly named as Category
dgdavid
force-pushed
the
improve-section-component
branch
from
November 24, 2022 10:30
4e926b9
to
1b18e98
Compare
dgdavid
force-pushed
the
improve-section-component
branch
from
November 25, 2022 00:33
a37fa15
to
d5bef53
Compare
Because it does not play well with all kind of icons :(
Which helped out to improve how icons are handled and rendered.
imobachgs
approved these changes
Nov 25, 2022
joseivanlopez
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed offline, it would be better to use composition instead of passing props, for example:
<Section>
<SectionAction />
</section>
And the same for the Fieldset
created in #333:
<Fieldset>
<Legend />
</Fieldset>
Agreed to change it in a refact PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Category
component needs some improvements now that we have pages too, not only the overview.Solution
To change a bit the component for fulfilling current needs.
Starting with a rename, the
Section
component now allowsScreenshots
Below, see a few examples by using just fake sections
Related to #321