Storage proposal: always do a clean install #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
D-Installer uses the
Y2Storage::GuidedProposal
under the hood. But some aspects of the default settings that make sense in the case of YaST and SLE/Leap are wrong or confusing for D-Installer and ALP.Additionally, when encrypting a volume in ALP that should be done with LUKS2 using PBKDF2 as key derivation function. All other "products" known by D-Installer use the traditional LUKS1.
See more at: https://trello.com/c/DWTHEhgU/3230-2-d-installer-adjust-storage-proposal-settings
Solution
Y2Storage::ProposalSettings
with a method marked as temporary.encryption_method
andencryption_pbkdf
are now configurable per-product atd-installer.yaml
.Bonus: fixed a hardcoded "1234" at
#hack_olaf_password
.Bonus2: added #338 to the changelog.
Testing
Relations
Depends on yast/yast-storage-ng#1316