-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc_update_oath_issue_gsc #17967
doc_update_oath_issue_gsc #17967
Conversation
We are currently blocked on some GCS OAuth workflows and we are adding a note to inform our customers.
@@ -7,6 +7,12 @@ This page contains the setup guide and reference information for the google sear | |||
|
|||
* Credentials to a Google Service Account \(or Google Service Account with delegated Domain Wide Authority\) or Google User Account | |||
|
|||
:::note | |||
|
|||
Google has depreciated [some OAuth workflows](https://developers.google.com/identity/protocols/oauth2/resources/oob-migration) that might impact you. We are in the process of working on a fix at the connector-level. Thank you for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change depreciated > deprecated
Delete "Thank you for your patience!"
Do we have a timeline for the fix? Also, do we have a workaround/alternative for now?
Are other connectors affected by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No timeline and as far as we know, this only impacts GSC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, if we don't have a timeline for the fix, we shouldn't mention it in docs. How about "Google has deprecated certain OAuth workflows. Before you use this connector, verify that the deprecated workflows don't impact your setup."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are working on a fix (GL backlog) but we don't have an official timeline as we don't fully understand the scope yet. Note that the OAuth deprecation affects our connector (in other word, customers are impacted as a result of an issue on our side, not their side) so I don't think we can ask them to check their workflows. Do you have some other suggestions on how we can best convey this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. In that case, I think we need to give users actionable guidance and ask them to use the alternative method (Service Account, I think?)
How about "Since Google has deprecated certain OAuth workflows, OAuth isn't supported for this connector." And then remove all OAuth-related content from the doc for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Amruta! I think that's fair for now. Can we say "Since Google has deprecated certain OAuth workflows, OAuth isn't supported for this connector at this time.". We are working on a fix so we don't want to give the impression that this is permanent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sounds good!
Approved and good to go
Fixed the wording and should be ready to go. @Amruta-Ranade |
* master: (304 commits) Bump helm chart version reference to 0.40.27 (#18152) Bump helm chart version reference to 0.40.26 (#18094) Update deployment.yaml (#18151) Publishes Postgres, MySQL, MSSQL source with changes from #18041 (#18086) Fix minor DBT Cloud Errors. (#18147) Sentry Integration : Stop reporting all non system-error error types. (#18133) Docs: Fix backoff stategy docs (#18143) 🐛 Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' (#17901) Add openAPI spec for Connector Builder Server (#17535) Alex/mvp UI for dbt cloud integration (#18095) increased timeout for sat tests (#18128) Bmoric/remove dep connector worker (#17977) `recordsRead` should be a long (#18123) doc_update_oath_issue_gsc (#17967) 🎉 Source Zendesk Chat: engagements data fix infinity looping + gradlew format (#18121) 🐛 Source Zendesk Chat: engagements data fix infinity looping (#17745) Custom APM Tracing (#17947) 11679 BigQuery-Denormalized Destination: improve code coverage (#17827) increased timeout for sat tests (#18114) docs: clarify language (#18090) ...
* doc_update_oath_issue_gsc We are currently blocked on some GCS OAuth workflows and we are adding a note to inform our customers. * Updated wording * Fixed wording for this connector Approved and good to go
We are currently blocked on some GCS OAuth workflows and we are adding a note to inform our customers.