Alex/mvp UI for dbt cloud integration #18095

mfsiega-airbyte · 2022-10-18T08:16:46Z

What

Prototype/MVP UI for dbt cloud integration.

How

Describe the solution

🚨 User Impact 🚨

Should be none; all new UI is behind feature flags and off by default

Corners cut

dbt cloud settings page
- doesn't give any confirmation feedback on submit
- doesn't validate a thing
- doesn't fetch existing record
- no way to delete dbt webhook config record once created, just overwrite its data
transformations tab
- no validation feedback besides submit button being en/disabled
- can only add one new job at a time
- didn't extract text content to i18n keys

Tests

It sure would have been nice to have time to write some!

To get the styling to work, I needed to edit `LabeledInput` to accept a `className` prop, so I could give it contextually-specific styling.

This feature isn't added to either OSS or cloud builds; it will be dynamically toggled for specific targeted accounts via LaunchDarkly's `featureService.overwrites` key.

This still uses some hardcoded conditions instead of anything resembling actual data

There's some key data missing and it's not currently wired up

ambirdsall · 2022-10-18T09:17:49Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+                        Transformations
+                        <Button
+                          variant="secondary"
+                          disabled={!!values.jobs.find((job: DbtCloudJob) => !job.operationId)}


This currently has a bug: the app doesn't add operationIds after submitting, so you can only ever add one job at a time without refreshing.

josephkmh

Left mostly non-blocking comments that you should feel free to ignore, but the core logic looks sound to me 👍 Most of my comments are also things I think we should discuss as a FE team anyway, so not really specific to this PR.

I did not test locally beyond seeing the dbt cloud integration settings page.

josephkmh · 2022-10-18T10:19:22Z

airbyte-webapp/src/packages/cloud/services/dbtCloud.ts

+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const [_fullUrl, account, job] = matches;


Suggested change

// eslint-disable-next-line @typescript-eslint/no-unused-vars

const [_fullUrl, account, job] = matches;

const [, account, job] = matches;

^ We don't assign unused variables any name, but instead skip them. This is happening in a couple of places around this PR, so we should try to remove all of those.

Somehow I didn't realize you can do that when destructuring; I like that much better than using throwaway variables and manually shushing the linter. Will do for all instances.

josephkmh · 2022-10-18T10:22:25Z

airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.module.scss

+@use "../../../../../scss/colors";
+@use "../../../../../scss/variables" as vars;


Suggested change

@use "../../../../../scss/colors";

@use "../../../../../scss/variables" as vars;

@use "scss/colors";

@use "scss/variables" as vars;

josephkmh · 2022-10-18T10:41:03Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+import classNames from "classnames";
+import { Field, Form, Formik, FieldArray, FieldProps } from "formik";
+import { Link } from "react-router-dom";
+import { array, object, number } from "yup";


nitpick: I've noticed we tend to alias the import import * as yup from "yup" - would adjust that here for consistency

josephkmh · 2022-10-18T11:36:45Z

airbyte-webapp/src/components/ui/CollapsablePanel/CollapsablePanel.tsx

+      })}
+    >
+      <div>
+        <button className={styles.arrow} tabIndex={0} onClick={toggleOpen}>


Accessibility improvement: would be good to add aria-expanded, aria-controls and aria-label to the button.

UX idea: add <label>{children}</label> so you can click on "Advanced options" as well as just the arrow button.

I think we might simply want to use the https://headlessui.com/react/disclosure component from headless UI, which we use in other places for collapsible elements, which handles all the accessibility. I know that the platform workflow team has also thought about creating a component for that now. @edmundito @dizel852 do you know if this is already started work on, since we should try to coordinate do not do that effort duplicate.

If we keep using button here it also won't require tabIndex, since that's the default value of the button element anyway.

UX idea: add {children} so you can click on "Advanced options" as well as just the arrow button.

Or children should just be part of the button completely. That one got me as well. Since I feel usually there is more content inside the collapsible than in the button, I'd suggest we make the drawer property just to be the children instead and add a buttonLabel property instead that renders inside the button, so we don't need to put the full content of the collapsiple into a property.

Yes that could also work, only drawback I see is that you might want icons/other JSX in the buttonLabel slot. IMO Tim's idea to use headlessui is probably the quickest and easiest. It also has a more verbose but composable API:

<Disclosure> <Disclosure.Button className="py-2"> Is team pricing available? </Disclosure.Button> <Disclosure.Panel className="text-gray-500"> Yes! You can purchase a license that you can share with your entire team. </Disclosure.Panel> </Disclosure>

josephkmh · 2022-10-18T12:12:38Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+                  <Card
+                    title={
+                      <span className={styles.jobListTitle}>
+                        Transformations


I guess it's already on your radar, but these components are all still using hard-coded strings instead of <FormattedMessage>. This one I would fix before merging, lest we forget.

josephkmh · 2022-10-18T12:22:47Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+            )}
+          </Field>
+        </div>
+        <button type="button" className={styles.jobListItemDelete} onClick={removeJob}>


Could add an aria-label here unless FontAwesomeIcon has some text label (I don't think it does?)

josephkmh · 2022-10-18T12:32:18Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  const dbtSettingsPath = `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Settings}/dbt-cloud`;
+  return (
+    <div className={classNames(className, styles.emptyListContent)}>
+      <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


Should we be using <Text> here?

we should :) It will also solve some default browser margin issues on p.

josephkmh · 2022-10-18T12:35:15Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+                    {hasDbtIntegration ? (
+                      <DbtJobsList jobs={values.jobs} remove={remove} isValid={isValid} />
+                    ) : (
+                      <NoDbtIntegration className={styles.jobListContainer} />


Should <Formik> even render if !hasDbtIntegration?

Ideally, no, since there's no need for it in that case. It's a detail I didn't have time to clean up: the Formik component was inside the DbtJobsList component until I wired up the "add new integration" button and realized I needed it to have access to the push function from FieldArray's render props.

josephkmh · 2022-10-18T13:26:50Z

airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.module.scss

+@use "../../../../../scss/colors";
+@use "../../../../../scss/variables" as vars;
+
+$item-spacing: 25px;


Would be great if we can use the spacing variables in scss/variables

timroes

(sending in between review states, because of the urgency)

timroes · 2022-10-18T16:04:18Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  const dbtSettingsPath = `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Settings}/dbt-cloud`;
+  return (
+    <div className={classNames(className, styles.emptyListContent)}>
+      <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


More hardcoded strings that still need to be i18n'ed before merging.

timroes · 2022-10-18T16:06:39Z

airbyte-webapp/src/components/ui/CollapsablePanel/CollapsablePanel.tsx

+      })}
+    >
+      <div>
+        <button className={styles.arrow} tabIndex={0} onClick={toggleOpen}>


If we keep using button here it also won't require tabIndex, since that's the default value of the button element anyway.

airbyte-webapp/src/components/ui/CollapsablePanel/CollapsablePanel.tsx

timroes · 2022-10-18T16:10:19Z

airbyte-webapp/src/packages/cloud/services/dbtCloud.ts

+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const [_fullUrl, account, job] = matches;


^ We don't assign unused variables any name, but instead skip them. This is happening in a couple of places around this PR, so we should try to remove all of those.

airbyte-webapp/src/components/ui/CollapsablePanel/CollapsablePanel.tsx

timroes · 2022-10-18T16:51:06Z

airbyte-webapp/src/packages/cloud/services/dbtCloud.ts

+  const { operationId } = operation;
+  const { executionUrl } = operation.operatorConfiguration.webhook || {};
+
+  const matches = (executionUrl || "").match(/\/accounts\/([^/]+)\/jobs\/([^]+)\//);


For my understanding, does it mean the job actually only stores the full execution URL, while we're entering in the UI individual separate fields?

I think the backend should store the fields we want the user to actually enter, and just build the executionUrl when doing the request. Parsing this client side sounds like a fragile method, and if we don't store this data now, we might have a problem addressing this in a backwards compatible way easily, since we already lost the individual field information.

Good callout! We did discuss this a bit.

The backend is actually unaware of dbt accounts/jobs, or dbt cloud at all - it's a "webhook operation", and it just holds the plain URL. dbt Cloud is a totally frontend concept at the moment.

With that said, I do think a better approach would be what you're describing, and the way I'd do it would be to accept the URL "template" that includes named params; plus a map of the params. e.g., "https://cloud.getdbt.com/api/v2/accounts/{accountId}/jobs/{jobId}/run/", {"accountId": "x", "jobId": "y"}.

I think for existing configs we would represent this like "https://cloud.getdbt.com/api/v2/accounts/x/jobs/y/run/", {}. Since dbt Cloud is going to be the only "webhook operation" integration in the UI for the foreseeable future, once we have the template, params representation we can run a targeted migration since we know what these look like, and then we'd be able to kill this bit of messy FE code.

@davinchia any thoughts here? I do agree we should make the change in the backend ~asap.

I 100% agree; I think there should be cloud endpoints which are specific to dbt Cloud, return the easy-to-use DbtCloudJob objects, and, down the line, support UI niceties like selecting dbt jobs from a dropdown (which has to go through the backend for CORS reasons) and the fact that these are backed by a generic webhook record remaining an implementation detail hidden from the frontend code. (In fact, it's one of the primary reasons I tried to keep all the API interactions contained to this single file.) It came up a bit in earlier discussions and it's something I'm going to advocate for in the immediate clean-up planning/spec work. Thoughts, @mfsiega-airbyte?

For what it's worth, this seems like a reasonable PR sequencing of that change if we do choose to ship the MVP with these API contracts still in place:

first an "append-only" PR to airbyte-cloud adding new dbt-Cloud-specific APIs (which wouldn't yet be used);

then full-stack PR to airbyte to define and generate those new APIs and replace all the webhook-oriented code in this file with them.

That said, in terms of this PR, I didn't have a working instance of this more minimal backend implementation to develop and experiment with until this weekend, so I had little choice but to run with what was available to get something working for the demo.

timroes · 2022-10-18T16:51:49Z

airbyte-webapp/src/packages/cloud/services/dbtCloud.ts

+  const connectionService = useWebConnectionService();
+
+  // TODO extract shared isDbtWebhookConfig predicate
+  const hasDbtIntegration = !isEmpty(workspace.webhookConfigs?.filter((config) => /dbt/.test(config.name || "")));


🎨 This looks like it could just be an .includes instead of a regexp (same the line below).

I got paranoid about locking in our ability to edit the webhook name if we decide to tweak the naming convention, but I think you're right that it would be cleaner just checking for the actual value, since it's not user-supplied

I'm not sure whether we meant the same thing, so just for clarification, I suggested just replacing the regexp by an includes not the whole filter statement, i.e.:

Suggested change

const hasDbtIntegration = !isEmpty(workspace.webhookConfigs?.filter((config) => /dbt/.test(config.name || "")));

const hasDbtIntegration = !isEmpty(workspace.webhookConfigs?.filter((config) => config.name?.includes("dbt")));

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx

timroes

Demoed it in pairprogramming and looked over the code. Seems to be good to merge for the demo, but will require several cleanup work afterwards.

We paired on improvements

timroes

Left several notes for cleanup. We try to not overdo it on Octavia illustrations in the product, to get to a more professional looking design. Maybe you could sync with Nico shortly about the empty state to get some ideas and input there.

timroes · 2022-10-18T20:21:35Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  <div className={classNames(styles.jobListContainer, styles.emptyListContent)}>
+    <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>
+    {jobs.length ? (
+      jobs.map((_j, i) => <JobsListItem key={i} jobIndex={i} removeJob={() => remove(i)} />)


🎨 Unused variable should simply be skipped.

Bindings in an argument list can't be skipped like they can when destructuring, though: it's a syntax error.

timroes · 2022-10-18T20:22:37Z

airbyte-webapp/src/packages/cloud/services/dbtCloud.ts

+    throw new Error(`Cannot extract dbt cloud job params from executionUrl ${executionUrl}`);
+  } else {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const [_fullUrl, account, job] = matches;


🎨 Other unused variable, that should be skipped in destructuring.

timroes · 2022-10-18T21:48:41Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+    ) : (
+      <>
+        <img src="/images/octavia/worker.png" alt="An octopus wearing a hard hat, tools at the ready" />
+        No transformations


i18n needed

timroes · 2022-10-18T21:48:46Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+    )}
+    <div className={styles.jobListButtonGroup}>
+      <Button className={styles.jobListButton} type="reset" variant="secondary">
+        Cancel


i18n needed

timroes · 2022-10-18T21:48:51Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+        Cancel
+      </Button>
+      <Button className={styles.jobListButton} type="submit" variant="primary" disabled={!dirty || !isValid}>
+        Save changes


i18n needed

timroes · 2022-10-19T09:19:04Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  const dbtSettingsPath = `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Settings}/dbt-cloud`;
+  return (
+    <div className={classNames(className, styles.emptyListContent)}>
+      <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


we should :) It will also solve some default browser margin issues on p.

timroes · 2022-10-19T09:22:20Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  const dbtSettingsPath = `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Settings}/dbt-cloud`;
+  return (
+    <div className={classNames(className, styles.emptyListContent)}>
+      <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


I'd remove this sentence in the integration not setup state, since it feels a bit weird telling, that the following transformations will run, while we know there are no transformations, and the user isn't setup yet. I'd maybe phrase it more like:

"To run dbt Cloud transformations when syncing data, setup your dbt Cloud account in the settings."

timroes · 2022-10-19T09:23:42Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  isValid: boolean;
+  dirty: boolean;
+}) => (
+  <div className={classNames(styles.jobListContainer, styles.emptyListContent)}>


It feels a bit weird, that we're attaching the emptyListContent classname here, no matter whether this list is empty or not.

timroes · 2022-10-19T09:23:45Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  dirty: boolean;
+}) => (
+  <div className={classNames(styles.jobListContainer, styles.emptyListContent)}>
+    <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


Should be <Text> (as Joey mentioned on an occasion below).

timroes · 2022-10-19T09:26:41Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  dirty: boolean;
+}) => (
+  <div className={classNames(styles.jobListContainer, styles.emptyListContent)}>
+    <p className={styles.contextExplanation}>After an Airbyte sync job has completed, the following jobs will run</p>


I think in case there are no jobs setup yet, we should not show this message, since we know there are no "following jobs". Maybe the empty state could be simply the image with the label below stating something along the lines of:

"No Transformations. You can add transformations to run when sync jobs have completed."

timroes · 2022-10-19T09:31:07Z

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx

+  return (
+    <Card className={styles.jobListItem}>
+      <div className={styles.jobListItemIntegrationName}>
+        <img src="/images/external/dbt-bit_tm.png" alt="dbt logo" />


Dbt offers their logos also in SVG format. We should exchange this via their SVG version.

* master: (304 commits) Bump helm chart version reference to 0.40.27 (#18152) Bump helm chart version reference to 0.40.26 (#18094) Update deployment.yaml (#18151) Publishes Postgres, MySQL, MSSQL source with changes from #18041 (#18086) Fix minor DBT Cloud Errors. (#18147) Sentry Integration : Stop reporting all non system-error error types. (#18133) Docs: Fix backoff stategy docs (#18143) 🐛 Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' (#17901) Add openAPI spec for Connector Builder Server (#17535) Alex/mvp UI for dbt cloud integration (#18095) increased timeout for sat tests (#18128) Bmoric/remove dep connector worker (#17977) `recordsRead` should be a long (#18123) doc_update_oath_issue_gsc (#17967) 🎉 Source Zendesk Chat: engagements data fix infinity looping + gradlew format (#18121) 🐛 Source Zendesk Chat: engagements data fix infinity looping (#17745) Custom APM Tracing (#17947) 11679 BigQuery-Denormalized Destination: improve code coverage (#17827) increased timeout for sat tests (#18114) docs: clarify language (#18090) ...

* Add lightly-styled ui for dbt cloud settings * Add CollapsablePanel component * Add CollapsablePanel around url input, MVP styling To get the styling to work, I needed to edit `LabeledInput` to accept a `className` prop, so I could give it contextually-specific styling. * Add new feature flag for dbt cloud integration This feature isn't added to either OSS or cloud builds; it will be dynamically toggled for specific targeted accounts via LaunchDarkly's `featureService.overwrites` key. * Put settings page dbt cloud ui behind feature flag * Add feature-flagged CloudTransformationsCard * Extract (and rename) DbtCloudTransformationsCard * Extract EmptyTransformationList component * List transformations if any, "no integration" UI This still uses some hardcoded conditions instead of anything resembling actual data * Initial UI for cloud transform jobs * Use formik-backed inputs for job list data fields * Improve job list management with FieldArray et al * WIP: build payload to save job data as operations There's some key data missing and it's not currently wired up * Start pulling dbt cloud business logic to its own module * Renaming pass (s/transformation/job/g) * Move more logic into dbt service module * Renaming pass (s/project/account/) * Improve useDbtIntegration hook * Add skeleton of updateWorkspace fn * Connect pages to actual backend (no new jobs tho) * Add hacky initial add new job implementation * Put the whole dbt cloud card inside FieldArray This dramatically simplifies adding to the list of jobs. * Fix button placement, loss of focus on input Never use the input prop in your component key, kids. * re-extract DbtJobsList component * Add input labels for dbt cloud job list * Validate dbt cloud jobs so bad data doesn't crash the party * Fix typo * Improve dirty form tracking for dbt jobs list * Remove unused input, add loading state to dbt cloud settings view * Handle no integration, dirty states in dbt jobs list Co-authored-by: Alex Birdsall <[email protected]>

github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker area/frontend Related to the Airbyte webapp labels Oct 18, 2022

ambirdsall force-pushed the alex/mvp-ui-for-dbt-cloud-integration branch from 0865bf0 to 72b719a Compare October 18, 2022 08:52

github-actions bot removed the area/documentation Improvements or additions to documentation label Oct 18, 2022

ambirdsall temporarily deployed to more-secrets October 18, 2022 08:55 Inactive

ambirdsall added 2 commits October 18, 2022 02:01

Add lightly-styled ui for dbt cloud settings

534ed71

Add CollapsablePanel component

a46c42c

ambirdsall force-pushed the alex/mvp-ui-for-dbt-cloud-integration branch from 72b719a to 42f2a3a Compare October 18, 2022 09:01

github-actions bot removed area/worker Related to worker area/server area/api Related to the api labels Oct 18, 2022

ambirdsall force-pushed the alex/mvp-ui-for-dbt-cloud-integration branch 2 times, most recently from fbba192 to 65ea077 Compare October 18, 2022 09:16

ambirdsall added 13 commits October 18, 2022 02:21

Add CollapsablePanel around url input, MVP styling

578113b

To get the styling to work, I needed to edit `LabeledInput` to accept a `className` prop, so I could give it contextually-specific styling.

Add new feature flag for dbt cloud integration

e3f8fbb

This feature isn't added to either OSS or cloud builds; it will be dynamically toggled for specific targeted accounts via LaunchDarkly's `featureService.overwrites` key.

Put settings page dbt cloud ui behind feature flag

54693cf

Add feature-flagged CloudTransformationsCard

39836db

Extract (and rename) DbtCloudTransformationsCard

e9bb481

Extract EmptyTransformationList component

94598fe

List transformations if any, "no integration" UI

8377b6a

This still uses some hardcoded conditions instead of anything resembling actual data

Initial UI for cloud transform jobs

c4a2f9e

Use formik-backed inputs for job list data fields

2286e36

Improve job list management with FieldArray et al

29ca6ab

WIP: build payload to save job data as operations

7c5fa85

There's some key data missing and it's not currently wired up

Start pulling dbt cloud business logic to its own module

5f946f6

Renaming pass (s/transformation/job/g)

a948409

ambirdsall added 3 commits October 18, 2022 02:21

Add input labels for dbt cloud job list

2cee9f5

Validate dbt cloud jobs so bad data doesn't crash the party

af02acf

Fix typo

b0e9079

ambirdsall requested review from timroes and josephkmh October 18, 2022 09:38

ambirdsall reviewed Oct 18, 2022

View reviewed changes

ambirdsall marked this pull request as ready for review October 18, 2022 09:38

ambirdsall requested a review from a team as a code owner October 18, 2022 09:38

josephkmh previously requested changes Oct 18, 2022

View reviewed changes

josephkmh reviewed Oct 18, 2022

View reviewed changes

ambirdsall force-pushed the alex/mvp-ui-for-dbt-cloud-integration branch from 65ea077 to b0e9079 Compare October 18, 2022 16:48

timroes reviewed Oct 18, 2022

View reviewed changes

...ionPage/pages/ConnectionItemPage/ConnectionTransformationTab/DbtCloudTransformationsCard.tsx Outdated Show resolved Hide resolved

timroes reviewed Oct 18, 2022

View reviewed changes

airbyte-webapp/src/packages/cloud/views/settings/integrations/DbtCloudSettingsView.tsx Outdated Show resolved Hide resolved

ambirdsall added 3 commits October 18, 2022 12:31

Improve dirty form tracking for dbt jobs list

923f332

Remove unused input, add loading state to dbt cloud settings view

ea8d8bc

Handle no integration, dirty states in dbt jobs list

76c69ec

timroes approved these changes Oct 18, 2022

View reviewed changes

Merge branch 'master' into alex/mvp-ui-for-dbt-cloud-integration

9d56031

ambirdsall merged commit 11699d4 into master Oct 18, 2022

ambirdsall deleted the alex/mvp-ui-for-dbt-cloud-integration branch October 18, 2022 20:59

timroes reviewed Oct 19, 2022

View reviewed changes

octavia-squidington-iii mentioned this pull request Oct 20, 2022

Bump Airbyte version from 0.40.15 to 0.40.16 #18268

Merged

		// eslint-disable-next-line @typescript-eslint/no-unused-vars
		const [_fullUrl, account, job] = matches;

	// eslint-disable-next-line @typescript-eslint/no-unused-vars
	const [_fullUrl, account, job] = matches;
	const [, account, job] = matches;

		@use "../../../../../scss/colors";
		@use "../../../../../scss/variables" as vars;

	const hasDbtIntegration = !isEmpty(workspace.webhookConfigs?.filter((config) => /dbt/.test(config.name \|\| "")));
	const hasDbtIntegration = !isEmpty(workspace.webhookConfigs?.filter((config) => config.name?.includes("dbt")));

Alex/mvp UI for dbt cloud integration #18095

Alex/mvp UI for dbt cloud integration #18095

Conversation

mfsiega-airbyte commented Oct 18, 2022 • edited by ambirdsall Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Corners cut

Tests

Choose a reason for hiding this comment

josephkmh left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ambirdsall Oct 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mfsiega-airbyte commented Oct 18, 2022 •

edited by ambirdsall

Loading

josephkmh left a comment •

edited

Loading

ambirdsall Oct 18, 2022 •

edited

Loading