Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishes Postgres, MySQL, MSSQL source with changes from #18041 #18086

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

ryankfu
Copy link
Contributor

@ryankfu ryankfu commented Oct 17, 2022

What

Bumps connector version for MySQL, Postgres and MSSQL with error handling within SshTunnel

How

Bumps version connector

Recommended reading order

  1. SshTunnel.java

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

No breaking changes, this will unlock the customer who was having issues getting past the check stage with an issue with setting up a SSH tunnel

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mssql
  • source-mysql-strict-encrypt
  • source-alloydb
  • source-mysql
  • source-postgres-strict-encrypt
  • source-alloydb-strict-encrypt
  • source-mssql-strict-encrypt

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3268959913
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3268959913
No Python unittests run

Build Passed

Test summary info:

All Passed

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268959666
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268959666
No Python unittests run

Build Passed

Test summary info:

All Passed

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3268961508
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3268961508
🐛 https://gradle.com/s/gnf2hvainkm7k

Build Failed

Test summary info:

Could not find result summary

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268962691
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268962691
No Python unittests run

Build Passed

Test summary info:

All Passed

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3268963894
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3268963894
🐛 https://gradle.com/s/tf656x4e3qssa

Build Failed

Test summary info:

Could not find result summary

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268963590
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3268963590
No Python unittests run

Build Passed

Test summary info:

All Passed

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/publish connector=connectors/source-postgres,connectors/source-mysql,connectors/source-mssql run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres,connectors/source-mysql,connectors/source-mssql
https://github.com/airbytehq/airbyte/actions/runs/3269479084


Connector Did it publish? Were definitions generated?
connectors/source-mysql
connectors/source-mssql
connectors/source-postgres

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

/publish connector=connectors/source-postgres-strict-encrypt,connectors/source-mysql-strict-encrypt,connectors/source-mssql-strict-encrypt auto-bump-version=false

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt,connectors/source-mysql-strict-encrypt,connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3269487302


Connector Did it publish? Were definitions generated?
connectors/source-mysql-strict-encrypt
connectors/source-mssql-strict-encrypt
connectors/source-postgres-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 17, 2022

NOTE: making a conscious effort to say that these version bumps should not be the reason the integration tests are failing. That said, added a personal note to fix the integration tests for source-mysql and source-mssql after updating the connector version that is affecting the usage of SshTunnel for source-mysql

Running integration on master to determine if these failures were originally occurring:

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-postgres,connectors/source-mysql,connectors/source-mssql run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres,connectors/source-mysql,connectors/source-mssql
https://github.com/airbytehq/airbyte/actions/runs/3269664977


Connector Did it publish? Were definitions generated?
connectors/source-postgres
connectors/source-mysql
connectors/source-mssql

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-mysql run-tests=false

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3269787437


Connector Did it publish? Were definitions generated?
connectors/source-mysql

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-mysql run-tests=false

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3275732801


Connector Did it publish? Were definitions generated?
connectors/source-mysql

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-mysql run-tests=false

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3277121767


Connector Did it publish? Were definitions generated?
connectors/source-mysql

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mysql-strict-encrypt
  • source-mysql
  • source-mssql-strict-encrypt
  • source-alloydb
  • source-alloydb-strict-encrypt
  • source-postgres-strict-encrypt
  • source-mssql

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets October 18, 2022 21:52 Inactive
@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-postgres run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/3277240407


Connector Did it publish? Were definitions generated?
connectors/source-postgres

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-alloydb-strict-encrypt
  • source-mssql-strict-encrypt
  • source-mysql
  • source-mssql
  • source-alloydb
  • source-mysql-strict-encrypt
  • source-postgres-strict-encrypt

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets October 18, 2022 22:17 Inactive
@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-mssql run-tests=false

🕑 Publishing the following connectors:
connectors/source-mssql
https://github.com/airbytehq/airbyte/actions/runs/3277382295


Connector Did it publish? Were definitions generated?
connectors/source-mssql

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-postgres-strict-encrypt
  • source-alloydb-strict-encrypt
  • source-mssql
  • source-alloydb
  • source-mssql-strict-encrypt
  • source-mysql-strict-encrypt
  • source-mysql

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets October 18, 2022 22:43 Inactive
@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 18, 2022

/publish connector=connectors/source-mssql-strict-encrypt run-tests=false auto-bump-version=false

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3277468693


Connector Did it publish? Were definitions generated?
connectors/source-mssql-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 19, 2022

/publish connector=connectors/source-mysql-strict-encrypt run-tests=false auto-bump-version=false

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3277784596


Connector Did it publish? Were definitions generated?
connectors/source-mysql-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu
Copy link
Contributor Author

ryankfu commented Oct 19, 2022

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false auto-bump-version=false

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3278835145


Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu ryankfu merged commit 8c780bd into master Oct 19, 2022
@ryankfu ryankfu deleted the ryan/bump-ssh-tunnel-no-next branch October 19, 2022 04:53
letiescanciano added a commit that referenced this pull request Oct 19, 2022
* master: (304 commits)
  Bump helm chart version reference to 0.40.27 (#18152)
  Bump helm chart version reference to 0.40.26 (#18094)
  Update deployment.yaml (#18151)
  Publishes Postgres, MySQL, MSSQL source with changes from #18041 (#18086)
  Fix minor DBT Cloud Errors. (#18147)
  Sentry Integration : Stop reporting all non system-error error types. (#18133)
  Docs: Fix backoff stategy docs (#18143)
  🐛 Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' (#17901)
  Add openAPI spec for Connector Builder Server (#17535)
  Alex/mvp UI for dbt cloud integration (#18095)
  increased timeout for sat tests (#18128)
  Bmoric/remove dep connector worker (#17977)
  `recordsRead` should be a long (#18123)
  doc_update_oath_issue_gsc (#17967)
  🎉 Source Zendesk Chat: engagements data fix infinity looping + gradlew format (#18121)
  🐛 Source Zendesk Chat: engagements data fix infinity looping (#17745)
  Custom APM Tracing (#17947)
  11679 BigQuery-Denormalized Destination: improve code coverage (#17827)
  increased timeout for sat tests (#18114)
  docs: clarify language (#18090)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…8041 (airbytehq#18086)

* Publishes Postgres, MySQL, MSSQL source with changes from airbytehq#18041

* auto-bump connector version

* auto-bump connector version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants