ledger: move non-lookup methods into a storage package #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4830 +/- ##
==========================================
- Coverage 53.99% 53.78% -0.21%
==========================================
Files 420 421 +1
Lines 53765 53789 +24
==========================================
- Hits 29029 28932 -97
- Misses 22359 22513 +154
+ Partials 2377 2344 -33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
force-pushed
the
refactor/accountdb-3
branch
from
8129aae
to
e3b3ab1
Compare
icorderi
force-pushed
the
refactor/accountdb-3
branch
from
e3b3ab1
to
93f7678
Compare
icorderi
force-pushed
the
refactor/accountdb-3
branch
from
93f7678
to
60efece
Compare
| "github.com/algorand/go-algorand/util/db" | ||
| ) | ||
|
|
||
| type accountsV2Reader struct { |
There was a problem hiding this comment.
why v2? is there is no accountsReader but AccountsReader. Call this differently to emphasize it is totals + round and not account data
There was a problem hiding this comment.
It will end up all in the same struct down the line.
A lot of this methods where free floating in the accountsdb file and called with the tx generated by doing atomics on the trackerDB.
algorandskiy
approved these changes
Nov 23, 2022
algorandskiy
changed the title
accountdb.go into a storage package (3 of N)
algorandskiy
changed the title
This was referenced Nov 28, 2022
This was referenced Dec 5, 2022
6 tasks
algolucky
pushed a commit
to algolucky/go-algorand
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving free methods that were related to the accounts db.
Staging them on a second type
accountsV2ReaderWriterwhile I move them out before figuring out how to put it all in a single thing.Previous parts of this refactor:
Test Plan
Existing tests.