-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger: new db methods to abstract queries needed by the deltas (9 of N) #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4864 +/- ##
==========================================
- Coverage 53.14% 53.09% -0.06%
==========================================
Files 427 427
Lines 54064 54080 +16
==========================================
- Hits 28732 28713 -19
- Misses 23068 23102 +34
- Partials 2264 2265 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
force-pushed
the
refactor/accountdb-9
branch
from
December 7, 2022 14:20
553885f
to
e523f7d
Compare
11 tasks
icorderi
force-pushed
the
refactor/accountdb-9
branch
from
December 7, 2022 23:51
e523f7d
to
70b8113
Compare
brianolson
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
algorandskiy
changed the title
refactor: accountdb.go into a store package (9 of N)
ledger: new db methods to abstract queries needed by the deltas (9 of N)
Dec 8, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a few more methods needed by the deltas.
Previous parts of this refactor:
What remains to be moved out:
orderedAccountsIter
catchpointPendingHashesIterator
accountsLoadOld
andresourcesLoadOld
have a couple queries that we might want to move out to avoid pulling all the deltas into storeTest Plan
Existing tests.