ledger: move iterators into a store package (10 of N) #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4874 +/- ##
==========================================
- Coverage 54.01% 53.57% -0.45%
==========================================
Files 426 429 +3
Lines 53425 53426 +1
==========================================
- Hits 28859 28624 -235
- Misses 22305 22573 +268
+ Partials 2261 2229 -32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
force-pushed
the
refactor/accountdb-10
branch
from
33fae92
to
c3bc2b9
Compare
|
top level package 'encoded' makes me wonder what encoded? maybe |
6 tasks
|
@brianolson they are mostly used in catchpoints, but leak on some of the db interfaces. |
icorderi
force-pushed
the
refactor/accountdb-10
branch
from
8ef5655
to
69a9144
Compare
algorandskiy
requested changes
Dec 14, 2022
| @@ -166,6 +167,14 @@ type catchpointCatchupAccessorImpl struct { | |||
| nextExpectedAccount basics.Address | |||
| } | |||
|
|
|||
| // catchpointAccountResourceCounter keeps track of the resources processed for the current account | |||
There was a problem hiding this comment.
there is a copy in store/encodedAccountsIter.go
There was a problem hiding this comment.
Yes, it's an accumulator used during iteration.
It seemed strange to export the type from store since it makes more sense for it to live here.
algorandskiy
approved these changes
Dec 15, 2022
algorandskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a few more methods needed by the deltas.
Previous parts of this refactor:
What remains to be moved out:
orderedAccountsItercatchpointPendingHashesIteratoraccountsLoadOldandresourcesLoadOldhave a couple queries that we might want to move out to avoid pulling all the deltas into storeledgeracctdeltas_test.goacctupdates_test.gocatchpointtracker.gocatchpointwriter.gocatchpointwriter_test.goTest Plan
Existing tests.