-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for algorand/go-algorand#5757 and algorand/go-algorand-sdk#617 #1605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
Lint Errors
idb/postgres/internal/encoding/encoding.go|667 col 27| ad.LastProposed undefined (type "github.com/algorand/go-algorand-sdk/v2/types".AccountData has no field or method LastProposed)
idb/postgres/internal/encoding/encoding.go|668 col 27| ad.LastHeartbeat undefined (type "github.com/algorand/go-algorand-sdk/v2/types".AccountData has no field or method LastHeartbeat)
idb/postgres/internal/encoding/encoding.go|668 col 27| too many errors) (typecheck)
Use latest sdk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
- Coverage 68.45% 68.45% -0.01%
==========================================
Files 37 37
Lines 7434 7452 +18
==========================================
+ Hits 5089 5101 +12
- Misses 1915 1920 +5
- Partials 430 431 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure why go-algorand-sdk
got donwgraded to 2.2.1 from 2.4
@@ -4,7 +4,7 @@ go 1.20 | |||
|
|||
require ( | |||
github.com/algorand/avm-abi v0.2.0 | |||
github.com/algorand/go-algorand-sdk/v2 v2.4.0 | |||
github.com/algorand/go-algorand-sdk/v2 v2.2.1-0.20240424151847-7914b596ba9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downgrade?
I believe this has been outdated by #1608? |
Summary
Updates to include changes from algorand/go-algorand#5757 and algorand/go-algorand-sdk#617
Depends on new SDK changes
Test Plan
TODO