Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for algorand/go-algorand#5757 and algorand/go-algorand-sdk#617 #1605

Closed
wants to merge 6 commits into from

Conversation

cce
Copy link
Contributor

@cce cce commented Apr 24, 2024

Summary

Updates to include changes from algorand/go-algorand#5757 and algorand/go-algorand-sdk#617
Depends on new SDK changes

Test Plan

TODO

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

Lint Errors

idb/postgres/internal/encoding/encoding.go|667 col 27| ad.LastProposed undefined (type "github.com/algorand/go-algorand-sdk/v2/types".AccountData has no field or method LastProposed)
idb/postgres/internal/encoding/encoding.go|668 col 27| ad.LastHeartbeat undefined (type "github.com/algorand/go-algorand-sdk/v2/types".AccountData has no field or method LastHeartbeat)
idb/postgres/internal/encoding/encoding.go|668 col 27| too many errors) (typecheck)

idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
idb/postgres/internal/encoding/encoding.go Show resolved Hide resolved
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.45%. Comparing base (8835d0f) to head (4984f24).
Report is 5 commits behind head on main.

Files Patch % Lines
api/handlers.go 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
- Coverage   68.45%   68.45%   -0.01%     
==========================================
  Files          37       37              
  Lines        7434     7452      +18     
==========================================
+ Hits         5089     5101      +12     
- Misses       1915     1920       +5     
- Partials      430      431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti marked this pull request as ready for review April 24, 2024 17:50
api/handlers.go Show resolved Hide resolved
api/handlers.go Show resolved Hide resolved
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why go-algorand-sdk got donwgraded to 2.2.1 from 2.4

@@ -4,7 +4,7 @@ go 1.20

require (
github.com/algorand/avm-abi v0.2.0
github.com/algorand/go-algorand-sdk/v2 v2.4.0
github.com/algorand/go-algorand-sdk/v2 v2.2.1-0.20240424151847-7914b596ba9b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downgrade?

@jasonpaulos
Copy link
Contributor

I believe this has been outdated by #1608?

@gmalouf gmalouf closed this May 8, 2024
@gmalouf gmalouf deleted the absenteeism branch May 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants