Absenteeism #1608
Merged
Absenteeism #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omitEmpty the new account fields
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
+ Coverage 68.45% 68.54% +0.08%
==========================================
Files 37 37
Lines 7434 7452 +18
==========================================
+ Hits 5089 5108 +19
+ Misses 1915 1914 -1
Partials 430 430 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Apr 26, 2024
| @@ -4,7 +4,7 @@ go 1.20 | |||
|
|
|||
| require ( | |||
| github.com/algorand/avm-abi v0.2.0 | |||
| github.com/algorand/go-algorand-sdk/v2 v2.4.0 | |||
| github.com/algorand/go-algorand-sdk/v2 v2.2.1-0.20240424151847-7914b596ba9b | |||
There was a problem hiding this comment.
Just leaving a note here so we remember to tag a new release before merge
cce
approved these changes
Apr 26, 2024
jasonpaulos
reviewed
Apr 29, 2024
There was a problem hiding this comment.
These changes look good, but I wanted to see some test coverage of the new fields, so I opened this: jannotti#1
Add unit tests for absenteeism
jasonpaulos
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with all the new fields for incentives