Migrate bevy_gizmos
#167
Merged
Migrate bevy_gizmos
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne#11477) # Objective Fixes bevyengine#11476 ## Solution Give the pipeline its own "mesh2d instances hashmap." Pretty sure this is a good fix, but I am not super familiar with this code so a rendering expert should take a look. > your fix in the pull request works brilliantly for me too. > -- _Discord user who pointed out bug_
# Objective - Better `SystemId` <-> `Entity` conversion. ## Solution - Provide a method `SystemId::from_entity` to create a `SystemId<I, O>` form an `Entity`. When users want to deal with the entities manually they need a way to convert the `Entity` back to a `SystemId` to actually run the system with `Commands` or `World`. - Provide a method `SystemId::entity` that returns an `Entity` from `SystemId`. The current `From` impl is not very discoverable as it does not appear on the `SystemId` doc page. - Remove old `From` impl. ## Migration Guide ```rust let system_id = world.register_system(my_sys); // old let entity = Entity::from(system_id); // new let entity = system_id.entity(); ``` --------- Co-authored-by: Alice Cecile <[email protected]>
# Objective - Currently all `ci` commands are in the `subcommands` module. This is problematic when you want to implement actually subcommands (such as `cargo r -p ci -- doc check`). - All command modules include the `_command` suffix, which is redundant. ## Solution - Move `commands` modules into root crate folder. - Merge contents of `commands/mod.rs` into `main.rs`. - Move `commands::subcommands` module into `commands` module. - Remove the `_command` suffix from all `commands::subcommands` modules.
# Objective - People have reported bounding volumes being slower than their existing solution because it doesn't use SIMD aligned types. ## Solution - Use `Vec3A` internally for bounding volumes, accepting `Into<Vec3A>` wherever possible - Change some code to make it more likely SIMD operations are used. --- ## Changelog - Use `Vec3A` for 3D bounding volumes and raycasts ## Migration Guide - 3D bounding volumes now use `Vec3A` types internally, return values from methods on them now return `Vec3A` instead of `Vec3`
# Objective remove repetitive words Signed-off-by: findmyhappy <[email protected]>
# Objective - Provide a way to iterate over the registered TypeData. ## Solution - a new method on the `TypeRegistry` that iterates over `TypeRegistrations` with theirs `TypeData` --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Gino Valente <[email protected]>
…bevyengine#13100) # Objective - The [`version`] field in `Cargo.toml` is optional for crates not published on <https://crates.io>. - We have several `publish = false` tools in this repository that still have a version field, even when it's not useful. [`version`]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field ## Solution - Remove the [`version`] field for all crates where `publish = false`. - Update the description on a few crates and remove extra newlines as well.
Tests are not yet updated and will fail, but `cargo check` succeeds.
BD103
force-pushed
the
linear-rgba-everywhere
branch
from
e103022
to
f0ac30c
Compare
Splitting this off into a separate issue.
|
Thanks! I think I agree with the choice to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now everything in
bevy_gizmosusesLinearRgba. I made all calls takeLinearRgbadirectly, notimpl Into<LinearRgba>, forcing the user to manually convert the colors.I also migrated all tests and a small portion of
bevy_dev_tools, with theInsetGizmo.