cloudfront_distribution doesn't honour enabled
#1823
Comments
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jun 1, 2023
cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
patchback bot
pushed a commit
that referenced
this issue
Jun 1, 2023
cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 5594769)
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this issue
Jun 1, 2023
…lections#1824) cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: ansible-collections#1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 5594769)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jun 1, 2023
[manual backport stable-5] cloudfront_distribution: now honours the enabled setting (#1824) cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz [email protected] Reviewed-by: Alina Buzachis (cherry picked from commit 5594769) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jun 1, 2023
[PR #1824/55947695 backport][stable-6] cloudfront_distribution: now honours the enabled setting This is a backport of PR #1824 as merged into main (5594769). SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this issue
Oct 24, 2023
…_workflows Divide github workflows to maintain consistency across all repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
When I try to create a distribution with
enabled: false, it will be created as enabled regardless.The problem is here:
We not only fall back to
self.__default_distribution_enabled(which isTrue) ifenabledisNone, but also when it'sFalse.Issue Type
Bug Report
Component Name
cloudfront_distribution
Ansible Version
Collection Versions
AWS SDK versions
Configuration
OS / Environment
Steps to Reproduce
- name: Create CloudFront Distribution cloudfront_distribution: profile: "{{ aws_profile }}" state: present enabled: false # ...Expected Results
I expected the distribution to be created in a disabled state.
Actual Results
The distribution is created as enabled.
Code of Conduct
The text was updated successfully, but these errors were encountered: