cloudfront_distribution: now honours the enabled setting #1824
Conversation
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 01s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
changelogs/fragments/1823-cloudfront_distribution_always_created_enabled.yml
Outdated
Show resolved
Hide resolved
|
Is it possible that you add an integration test that covers this case @gsimon75? |
markuman
added
backport-5
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 37s |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
gsimon75
force-pushed
the
issue_1823_cloudfront_distribution_always_created_enabled
branch
from
9784bc6
to
d3e8a8c
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5594769 on top of patchback/backports/stable-5/5594769527aee560fb454170f9dde31af3ff8c48/pr-1824 Backporting merged PR #1824 into main
🤖 @patchback |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1834 🤖 @patchback |
cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 5594769)
…lections#1824) cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: ansible-collections#1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 5594769)
[manual backport stable-5] cloudfront_distribution: now honours the enabled setting (#1824) cloudfront_distribution: now honours the enabled setting SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz [email protected] Reviewed-by: Alina Buzachis (cherry picked from commit 5594769) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
[PR #1824/55947695 backport][stable-6] cloudfront_distribution: now honours the enabled setting This is a backport of PR #1824 as merged into main (5594769). SUMMARY Fixes: #1823 The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
Fixes: #1823
The
enabled: falsesetting was ignored, because here we were falling back to the defaultTruenot only when the setting wasNone, but also when it wasFalse.ISSUE TYPE
COMPONENT NAME
cloudfront_distribution