Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual backport stable-5] cloudfront_distribution: now honours the enabled setting (#1824) #1837

Conversation

alinabuzachis
Copy link
Contributor

cloudfront_distribution: now honours the enabled setting

SUMMARY
Fixes: #1823
The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False. ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Markus Bergholz [email protected]
Reviewed-by: Alina Buzachis
(cherry picked from commit 5594769)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

…lections#1824)

cloudfront_distribution: now honours the enabled setting

SUMMARY
Fixes: ansible-collections#1823
The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit 5594769)
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a969142345d44d9085a9dbeaae8c41f9

ansible-galaxy-importer FAILURE in 5m 44s
✔️ build-ansible-collection SUCCESS in 13m 39s
ansible-test-sanity-docker-devel FAILURE in 10m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 23m 12s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 33s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 32s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 18s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 41s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 14s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 04s
✔️ ansible-test-changelog SUCCESS in 4m 54s
✔️ ansible-test-splitter SUCCESS in 5m 32s
Skipped 22 jobs

@markuman
Copy link
Member

markuman commented Jun 1, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6d3da3e30dd64d7a9fa94dd44d23dec2

✔️ ansible-galaxy-importer SUCCESS in 5m 14s
✔️ build-ansible-collection SUCCESS in 14m 17s
ansible-test-sanity-docker-devel FAILURE in 14m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 50s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 37s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 59s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 14m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 59s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 16s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 09s
✔️ ansible-test-changelog SUCCESS in 5m 12s
✔️ ansible-test-splitter SUCCESS in 6m 21s
Skipped 22 jobs

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jun 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/fcafe17b4de340449c0acdebfb991c4c

✔️ ansible-galaxy-importer SUCCESS in 3m 32s
✔️ build-ansible-collection SUCCESS in 13m 11s
ansible-test-sanity-docker-devel FAILURE in 15m 48s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 55s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 16m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 15m 02s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 41s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 31s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 37s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 48s
✔️ ansible-test-changelog SUCCESS in 4m 37s
✔️ ansible-test-splitter SUCCESS in 4m 51s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4d55e01 into ansible-collections:stable-5 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants