This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Release/1.29.0 #13
Merged
Release/1.29.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1545) * Use 'gulp-documentation' instead of jsdoc2md * Build Markdown instead (more versatile) * Update package.json per review feedback Specifically: - Alphabetize list of deps - Prepend "^" to package versions * Update yarn.lock alongside package.json
* Create yieldmoBidAdapter file * Copy over TL adapter and change name spacing * Update bid adapter naming to Yieldmo * Init tests for yieldmoBidAdapter * Add yeildmo config to pbjs_example_gpt * feature/yieldmoBidAdapter: added request build * Update ym response to have placement and impression level info * Remove environment param * Update ym tests for single bid request structure * Update url to use _ instead of camelcase * Update YMCB to handle multiple placements in one response * Clean up and remove TODO from adapter * Update response tests to work with single response structure * Remove trailing space * Cleanup * Adjusted code according to CR comments * Update bid adapter with fallback for incorrect bid response * Update yeildmo prebid endpoint * Add check to make sure response is an Array * Remove environment tracking as we are no going to use this * Update test to pass with new Yieldmo endpoint * Update return obj and remove node debug comments * Remove changes to hello_world and yarn.lock files * Remove unneeded comments
* Added tremor bid adapter for prebid.js * - Fixed some tests. * - Added some comments and changed a few variable names to be in line with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url. * - Some formatting. * - Removed the vastUrl field from the adapter.
…rebid#1570) * allow bundle task to be run programmatically from node * add bundle-to-stdout task to gulpFile.js * fixed bug with double-prepending __dirname in module bundling
* Added a base adapter for single-request adapters, and ported the appnexusAst adapter onto it * Renamed the SingleRequestBidder to BidderFactory. Updated it to handle multi-request architecture adapters. * Added a unit test for the delayExecution function. * Made newBidder a default import. Added some unit tests. * Added more tests. * Added more tests, and fixed a few bugs. * Changed an error to a log message. Fixed a small bug. * Did the no-brainer improvements from PR comments. * Added spec-level support for aliases and mediaTypes. Aliases may still be broken. * Added support for aliases. Added more tests * Cleaned up some unnecessary code. * Removed the GET/POST constants. Fixed some typos, and renamed some Request-related properties for consistency with the native object. * Re-added some code for outstream rendering, which was apparently lost in the merges somewhere. * Removed confusing use of this * Fixed lint error * Moved JSON parsing into the bidderFactory, and moved the JSDocs to the top. * Removed placementCode from everywhere I could.
Update tests to match.
* Add support for video stream context * Define adapter as supporting video * Use mediaTypes param to specify context * Use utils.deepAccess * Check for outstream bids * Add JSDoc and validation * Rename functions and add unit test * Update property name * Update stubs to new sinon stub syntax * Only check context when mediaTypes.video was defined * Retain video-outstream compatibility * Revert to Sinon 1 syntax * Server and bid response ad type for any stream type is always 'video' * Update to address code review
* Adding Orbitsoft module * Adding Orbitsoft module (corrected) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to new constructor) * Adding Orbitsoft module (delete unnecessary aliases) * Adding Orbitsoft module (delete unnecessary aliases)
* Add new user sync module * Rename user sync file * Reset image pixel queue after firing pixels * Added unit test for user sync * Fixed typo * Overlooked conflict from master * Improvements based on peer feedback for user sync * Added global user sync config * Allow auto-syncing override * Prevent syncing if there is no cookie support * Only trigger sync once per page * Limit number of user syncs per bidder * User syncs should fire pixels without adding element to DOM * Randomize user sync order by type * Comment about shuffling user syncs * Remove karma.conf.js and fix unused default value * Fix prebid server adapter test to use the right cookie function * Added iframe support to user sync * Fix oversights for user sync * Move try catch block for user sync * Option to disable user sync * Enable specific bidders for user sync * Encapsulate the user sync module Protect the user sync scope * Remove unused functions for user sync * Clean merge markers * fix usersync test problems * added setConfig to userSync * fixed lint problem * Change override user sync API and how user sync uses config * Fixed registerSync API to avoid spread operator * Fixed issues from last conflict resolution * Small refactoring to inject dependencies better. * Added a test for when user syncs are disabled. * Implemented usersync in the base adapter. * user-sync updates * not tracking client bidder syncs
* Connectad alias, request-level configuration, new ad sizes - Add 3 new ad sizes. - Create connectad alias. - Refactor to support whitelabel URLs by alias. - Add support for window.<ADAPTER>_CONFIG object for request level params. * Add oft-media alias for serverbid * serverbidBidAdapter:Fixed formatting issues * Serverbid: Updated smartsync urls, removed oft-media alias
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter
* Renamed areParamsValid to isBidRequestValid. Added the bidrequest to interpretResponse. * Changed areParamsValid into isBidRequestValid. * Updated the unit tests.
* fix for prebid#1582 * fixed typo and add unit tests
…e/Prebid-official-0.29.0
…ture/Prebid-official-0.29.0
Fixes unit tests for AOL adapter.
…LMP-208-update-aol-adapter to release/1.29.0 * commit '285f58f619357725fefdeb6ed4d610fb9bccf033': Add support for secure bid requests for one mobile get endpoint. Fixed adding undefined value for request without data Fixed wrong userSyncs type for image tags Updated unit tests for AOL userSyncOn. Added support for dropping pixels after bid response. Improved code formatting, fixed typos. Added userSync feature for aol adapter. Added test cases for contentType and headers. Fixes unit tests for AOL adapter. Added cpm adjustment warning. Added initial support for unit tests. Added drop pixels support. Added bid response handler. Converted AOL bid adapter to Prebid 1.0.
….29.0 to aolgithub-master * commit 'd7a1d285acbf95fad7562f1c0077ea99df9e5976': (45 commits) Added changelog entry. Add support for secure bid requests for one mobile get endpoint. Fixed adding undefined value for request without data Fixed wrong userSyncs type for image tags Updated unit tests for AOL userSyncOn. Added support for dropping pixels after bid response. Improved code formatting, fixed typos. Added userSync feature for aol adapter. Added test cases for contentType and headers. Fixes unit tests for AOL adapter. Added cpm adjustment warning. Added initial support for unit tests. Added drop pixels support. Added bid response handler. Converted AOL bid adapter to Prebid 1.0. Added changelog entry. Added new aol partners ids. Prebid 0.29.0 Release Fix for not syncing bidders. (prebid#1598) fix amp example pages (prebid#1597) closes prebid#1298 (prebid#1583) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating AOL Container Tag to 0.29.0