Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSRE-9] - Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 #1335

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

haroldwoo
Copy link
Contributor

@haroldwoo haroldwoo commented Jul 8, 2021

Why 1.10.15 initially?

https://airflow.apache.org/docs/apache-airflow/2.1.0/upgrading-to-2.html#step-2-upgrade-to-airflow-1-10-15-a-k-a-our-bridge-release

Changelogs of potential note to review (from 1.10.13 -> 1.10.15):

full list (https://airflow.apache.org/docs/apache-airflow/stable/changelog.html#airflow-1-10-15-2021-03-17)

TODO:

  • resolve pip dependencies
  • review changelogs
  • resolve - Broken DAG: [/app/dags/mozfun.py] cannot import name '_check_google_client_version' from 'pandas_gbq.gbq' (/usr/local/lib/python3.7/site-packages/pandas_gbq/gbq.py)
  • Test containers
  • Diff 1.10.15 and 1.10.12 code for dags/operators/gcp_container_operator, and dataproc operators for moz_dataproc_operator usage. Also s3_to_gcs_transfer_operator

Test jobs

  • GKEPodOperator
  • Dataproc (taar_lite standalone, use {{yesterday_ds}} as date)

Test plugins

  • backfill plugin
  • Mozilla docs

Addl note:
In 1.10.15, Adding Operators, Hooks and Sensors via Airflow Plugins is deprecated
The ability to import Operators, Hooks and Sensors via the plugin mechanism has been deprecated and will raise warnings in Airflow 1.10.13 and will be removed completely in Airflow 2.0.
Check https://airflow.apache.org/docs/1.10.13/howto/custom-operator.html to see how you can create and import Custom Hooks, Operators and Sensors.
In the plugins folder these may be effected?

  • log_email_backend.py
  • celery_visibility_timeout_fix.py

@haroldwoo haroldwoo added the wip label Jul 8, 2021
@haroldwoo haroldwoo changed the title WIP - Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 WIP - [DSRE-9] -Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 Jul 8, 2021
@haroldwoo haroldwoo changed the title WIP - [DSRE-9] -Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 [DSRE-9] -Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 Jul 8, 2021
@haroldwoo haroldwoo changed the title [DSRE-9] -Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 [DSRE-9] - Upgrade Airflow wtmo to 1.10.15 bridge release prior to 2.0 Jul 8, 2021
@haroldwoo haroldwoo removed the wip label Jul 19, 2021
@haroldwoo haroldwoo removed the request for review from whd July 19, 2021 21:41
Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, since this is primarily a release with backported functionality. Have you run airflow upgrade_check?

@haroldwoo
Copy link
Contributor Author

Not yet. The upgrade_check is for 1.10 to 2.0

@haroldwoo haroldwoo merged commit 9bd76d2 into mozilla:main Jul 20, 2021
@haroldwoo haroldwoo deleted the ta-110-15 branch July 20, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants