-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace underscore with modern JS #772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 85.71% 85.63% -0.09%
==========================================
Files 50 50
Lines 2598 2582 -16
==========================================
- Hits 2227 2211 -16
Misses 371 371
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice! 👍 As part of the work I been doing on the draft branched for all tooling repos, I been looking to deprecate the I forgot which repo exactly I was looking at, at the time, but good to see and know that this PR already existed. When I started the draft branches I forgot to check all PRs :D. |
Because we can. The only logical difference should be that
Object.assign
takes own enumerable props, while_.extend
enumerable.Resolves #643