Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace underscore with modern JS #772

Merged
merged 7 commits into from
Oct 10, 2019

Conversation

raphinesse
Copy link
Contributor

Because we can. The only logical difference should be that Object.assign takes own enumerable props, while _.extend enumerable.

Resolves #643

@raphinesse raphinesse added this to the 9.1.0 milestone Apr 13, 2019
@raphinesse raphinesse requested review from dpogue and erisu April 13, 2019 22:58
@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #772 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   85.71%   85.63%   -0.09%     
==========================================
  Files          50       50              
  Lines        2598     2582      -16     
==========================================
- Hits         2227     2211      -16     
  Misses        371      371
Impacted Files Coverage Δ
src/cordova/compile.js 100% <ø> (ø) ⬆️
src/plugman/variable-merge.js 100% <100%> (ø) ⬆️
src/cordova/platform/addHelper.js 95.54% <100%> (-0.03%) ⬇️
src/cordova/prepare.js 100% <100%> (ø) ⬆️
src/cordova/run.js 100% <100%> (ø) ⬆️
src/cordova/emulate.js 100% <100%> (ø) ⬆️
src/plugman/util/dependencies.js 92.1% <100%> (-1.08%) ⬇️
src/plugman/uninstall.js 93.5% <100%> (-0.05%) ⬇️
src/plugman/install.js 90.9% <100%> (-0.04%) ⬇️
src/plugman/fetch.js 86.06% <100%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07cddfc...3342580. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit b158ff0 into apache:master Oct 10, 2019
@raphinesse raphinesse deleted the replace-underscore branch October 10, 2019 14:59
@erisu
Copy link
Member

erisu commented Oct 11, 2019

Nice! 👍

As part of the work I been doing on the draft branched for all tooling repos, I been looking to deprecate the underscore dependency.

I forgot which repo exactly I was looking at, at the time, but good to see and know that this PR already existed.

When I started the draft branches I forgot to check all PRs :D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of underscore, maybe replace it with lodash
4 participants