fix: add undeclared dependency underscore
#869
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
Motivation and Context
cordova-lib
depends onunderscore
but doesn't declare it as a dependencycordova-lib/src/cordova/serve.js
Line 24 in 5cc0a79
cordova-lib/src/cordova/requirements.js
Line 20 in b9ad92a
It was declared correctly before but seems to have been removed in #772
Ref apache/cordova-ios#1105
Description
Added
underscore
as a dependencyTesting
Ran
cordova prepare
under a strict dependency environmentChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)