Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add undeclared dependency underscore #869

Closed
wants to merge 1 commit into from

Conversation

merceyz
Copy link

@merceyz merceyz commented Jun 4, 2021

Platforms affected

All

Motivation and Context

cordova-lib depends on underscore but doesn't declare it as a dependency

const { template, object: zipObject } = require('underscore');

const { object: zipObject } = require('underscore');

It was declared correctly before but seems to have been removed in #772

Ref apache/cordova-ios#1105

Description

Added underscore as a dependency

Testing

Ran cordova prepare under a strict dependency environment

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@raphinesse
Copy link
Contributor

Thanks a lot for spotting this and bringing it up here! I would rather remove the hidden dependency on underscore than to declare it (see #871). But let's see if someone else has an opinion on that.

@merceyz merceyz deleted the merceyz/fix/underscore branch June 23, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants