Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove undeclared dependency on underscore #871

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jun 6, 2021

Motivation and Context

This removes usage of underscore that were introduced after merging #772.

Closes #869

Description

I rewrote the two remaining usages of underscore using plain JS.

Testing

Automated test suite

@raphinesse raphinesse added the bug label Jun 6, 2021
@raphinesse raphinesse added this to the 10.0.1 milestone Jun 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #871 (86e1aa4) into master (cf5c487) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   91.18%   91.13%   -0.06%     
==========================================
  Files          45       45              
  Lines        2054     2053       -1     
==========================================
- Hits         1873     1871       -2     
- Misses        181      182       +1     
Impacted Files Coverage Δ
src/cordova/requirements.js 54.54% <0.00%> (-9.10%) ⬇️
src/cordova/serve.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5c487...86e1aa4. Read the comment docs.

@raphinesse raphinesse marked this pull request as ready for review June 8, 2021 07:38
@raphinesse raphinesse merged commit 3274a78 into apache:master Jun 23, 2021
@raphinesse raphinesse deleted the fix-remove-underscore branch June 23, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants