[WIP]feat: add provider code #2379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement cache manager * add meta cache * updata go mod * improve code * improve code * improve init time * update cache * fix bug * improve code * improve code * improve code
DMwangnima
requested changes
Aug 13, 2023
provider/provider.go
Outdated
| Meta map[string]interface{} | ||
| } | ||
|
|
||
| func NewProvider(opts ...ServiceOption) (*Provider, error) { |
There was a problem hiding this comment.
Change the name of package and struct from provider to server. Refer(#2378).
provider/service_config.go
Outdated
| } | ||
|
|
||
| // ExportMethod exports the service | ||
| func (s *ServiceConfig) ExportMethod() error { |
There was a problem hiding this comment.
There should be Export and ExportWithInfo like Refer and ReferWithInfo.
justxuewei
reviewed
Aug 14, 2023
common/constant/key.go
Outdated
Comment on lines
419
to
427
|
|
||
| // default meta cache config | ||
| const ( | ||
| DefaultMetaCacheName = "dubbo.meta" | ||
| DefaultMetaFileName = "dubbo.metadata" | ||
| DefaultEntrySize = 100 | ||
| ) |
There was a problem hiding this comment.
These lines of code should not belong to this patch. Please pull from the latest main branch and rebase onto it.
* Fix: Increase the dump interval for cache manager test * fix bug
Fixes #2382. The condition of assigning a random port for protocols should be that port is less than or equal to 0, not the length of the port string.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under continuous dev.