Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rustyline to 10.0.0 #2031

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Upgrade rustyline to 10.0.0 #2031

merged 1 commit into from
Aug 2, 2022

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Aug 2, 2022

rustyline 10.0.0 includes a breaking change where Editor::new now
returns result. The REPL propagates this error as an unhandled readline
error, which will exit the REPL with an error message.

This is a handcrafted version of @dependabot's PR in #1999 to address
this breaking change.

rustyline 10.0.0 includes several commits (a few of which I authored)
that reduce the number of deps pulled in a bunch:

`rustyline` 10.0.0 includes a breaking change where `Editor::new` now
returns result. The REPL propagates this error as an unhandled readline
error, which will exit the REPL with an error message.

This is a handcrafted version of @dependabot's PR in #1999 to address
this breaking change.

`rustyline` 10.0.0 includes several commits (a few of which I authored)
that reduce the number of deps pulled in a bunch:

- kkawakam/rustyline#613
- kkawakam/rustyline#614
- kkawakam/rustyline#615
- kkawakam/rustyline#623
@lopopolo lopopolo added A-deps Area: Source and library dependencies. A-frontend Area: Frontends for interpreters, like the `ruby` or `irb` binaries. labels Aug 2, 2022
@lopopolo lopopolo merged commit 6c5f137 into trunk Aug 2, 2022
@lopopolo lopopolo deleted the lopopolo/rustyline-10.0.0 branch August 2, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Source and library dependencies. A-frontend Area: Frontends for interpreters, like the `ruby` or `irb` binaries.
Development

Successfully merging this pull request may close these issues.

1 participant