Explore removing SmallVec from Event enum
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ cargo tree
...
├── radix_trie v0.2.1
│ ├── endian-type v0.1.2
│ └── nibble_vec v0.1.0
│ └── smallvec v1.8.0
├── smallvec v1.8.0 |
|
😅 I am hoping to follow up with additional PRs that make the |
I've followed up on this here: #615 |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Aug 2, 2022
`rustyline` 10.0.0 includes a breaking change where `Editor::new` now returns result. The REPL propagates this error as an unhandled readline error, which will exit the REPL with an error message. This is a handcrafted version of @dependabot's PR in #1999 to address this breaking change. `rustyline` 10.0.0 includes several commits (a few of which I authored) that reduce the number of deps pulled in a bunch: - kkawakam/rustyline#613 - kkawakam/rustyline#614 - kkawakam/rustyline#615 - kkawakam/rustyline#623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores removing the dependency on
smallvecand replacing it withVecfromstd.smallvecis a third party dependency that leaks into the public API. If applications that depend onrustylinewish to create custom key bindings, they must also depend onsmallvecto constructEvent::KeySeq.This PR replaces
smallvec, which is a complicated data structure with lots of unsafe code and several known security advisories, with a vocabulary type fromstd.This has the effect of reducing the size of the
Eventenum.Because
Eventis a public enum, changing the type of the field inEvent::KeySeqis a breaking change. I've shown this change in the sequence of commits in this branch and the addition of a test.Motivation of this PR is reducing dependencies.
@gwenn if you'd prefer, I'd be willing to try an alternate PR that conditionally enables
smallvecwith a Cargo feature. I think it looks easy enough to support.