Replace buf_redux with BufReader from std
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rustyline` depends on `buf_redux` for two calls to `get_len`, but these calls can be replaced with calls to `reader.buffer().len()` using APIs in `std` that have been available since Rust 1.37.0: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer `std::io::BufReader::buffer` does not cause any additional reads to occur and exposes the internal buffered and unread contents of the `BufReader`. Motivation for this commit is reducing dependencies.
|
Indeed, thanks. |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Aug 2, 2022
`rustyline` 10.0.0 includes a breaking change where `Editor::new` now returns result. The REPL propagates this error as an unhandled readline error, which will exit the REPL with an error message. This is a handcrafted version of @dependabot's PR in #1999 to address this breaking change. `rustyline` 10.0.0 includes several commits (a few of which I authored) that reduce the number of deps pulled in a bunch: - kkawakam/rustyline#613 - kkawakam/rustyline#614 - kkawakam/rustyline#615 - kkawakam/rustyline#623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustylinedepends onbuf_reduxfor two calls toget_len, but thesecalls can be replaced with calls to
reader.buffer().len()using APIsin
stdthat have been available since Rust 1.37.0:https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer
std::io::BufReader::bufferdoes not cause any additional reads tooccur and exposes the internal buffered and unread contents of the
BufReader.Motivation for this commit is reducing dependencies.