Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_velocity_converter): simpify parameter inputs #1727

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 30, 2022

Signed-off-by: kminoda [email protected]

Description

I propose to simplify the parameter input of vehicle_velocity_converter. Since the 6x6 matrix input is too redundant, the node should be provided with only two essential values, the standard deviation of vx and wz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda self-assigned this Aug 30, 2022
@kminoda kminoda added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 30, 2022
@kminoda kminoda marked this pull request as ready for review August 30, 2022 05:05
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1727 (95e7dcf) into main (74e28ed) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   10.25%   10.25%   -0.01%     
==========================================
  Files        1204     1204              
  Lines       86697    86706       +9     
  Branches    20020    20020              
==========================================
  Hits         8894     8894              
- Misses      68541    68550       +9     
  Partials     9262     9262              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.24% <0.00%> (ø) Carriedforward from b8a1f85

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._velocity_converter/vehicle_velocity_converter.hpp 0.00% <ø> (ø)
...ocity_converter/src/vehicle_velocity_converter.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YamatoAndo
Copy link
Contributor

I think the 6x6 matrix would be fine as its input, but I would like to respect your opinion.

@kminoda kminoda merged commit fbcfee1 into autowarefoundation:main Aug 30, 2022
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
1222-takeshi added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2022
…undation#1727) (#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
Co-authored-by: kminoda <[email protected]>
@kminoda kminoda deleted the fix/simplify_vehicle_velocity_converter_parameter_input branch September 15, 2022 07:56
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2022
…undation#1727) (#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
Co-authored-by: kminoda <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…undation#1727)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
…undation#1727) (autowarefoundation#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <[email protected]>

* fix readme and default value

Signed-off-by: kminoda <[email protected]>

* fix default value

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>

Signed-off-by: kminoda <[email protected]>
Co-authored-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants