Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dummy_perception_publisher): publish object with acc #1853

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 13, 2022

Signed-off-by: Takayuki Murooka [email protected]

Description

publish dummy object with designated acceleration

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

2022-09-14-01-31-27.mp4

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review September 13, 2022 07:26
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 marked this pull request as draft September 13, 2022 07:34
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1853 (e408d3d) into main (7280f98) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   10.46%   10.44%   -0.03%     
==========================================
  Files        1224     1224              
  Lines       87705    87902     +197     
  Branches    20462    20462              
==========================================
  Hits         9177     9177              
- Misses      69151    69348     +197     
  Partials     9377     9377              
Flag Coverage Δ *Carryforward flag
differential 4.72% <0.00%> (?)
total 10.44% <0.00%> (ø) Carriedforward from 7280f98

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_perception_rviz_plugin/src/tools/car_pose.cpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/interactive_object.cpp 0.00% <0.00%> (ø)
...rception_rviz_plugin/src/tools/pedestrian_pose.cpp 0.00% <0.00%> (ø)
..._perception_rviz_plugin/src/tools/unknown_pose.cpp 0.00% <0.00%> (ø)
simulator/dummy_perception_publisher/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yukkysaito
Copy link
Contributor

@takayuki5168 can you add min-max range for velocity?

@takayuki5168 takayuki5168 marked this pull request as ready for review September 13, 2022 16:33
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Sep 13, 2022

@yukkysaito DONE. Please check the video above.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit c50b25e into autowarefoundation:main Sep 14, 2022
@takayuki5168 takayuki5168 deleted the feat/pub-object-with-acc branch September 14, 2022 01:05
@takayuki5168
Copy link
Contributor Author

cc @soblin @kyoichi-sugahara

satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 14, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 14, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 14, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 28, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 15, 2022
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 18, 2023
…undation#1853)

* feat(dummy_perception_publisher): publish object with acc

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants