Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component_interface_specs): add missing dep #2035

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 7, 2022

Description

Package component_interface_specs uses messages from package autoware_adapi_v1_msgs which is missing from the dependency of package.xml. This can cause errors when building Autoware from scratch.
This PR adds the missing dependency.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem self-assigned this Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 10.41% // Head: 10.41% // No change to project coverage 👍

Coverage data is based on head (f343837) compared to base (365c725).
Patch has no changes to coverable lines.

❗ Current head f343837 differs from pull request most recent head 1f44921. Consider uploading reports for the commit 1f44921 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2035   +/-   ##
=======================================
  Coverage   10.41%   10.41%           
=======================================
  Files        1169     1169           
  Lines       83523    83523           
  Branches    19552    19552           
=======================================
  Hits         8695     8695           
  Misses      65452    65452           
  Partials     9376     9376           
Flag Coverage Δ *Carryforward flag
differential 13.08% <ø> (?)
total 10.39% <ø> (ø) Carriedforward from 365c725

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants