-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_velocity_smoother): change max_lateral_accel from 0.8 to 1.0 #2057
feat(motion_velocity_smoother): change max_lateral_accel from 0.8 to 1.0 #2057
Conversation
Signed-off-by: Maxime CLEMENT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maxime-clem |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By discussion with Max-san, we'd better apply the change only to the specific vehicle.
Following discussions with @TakaHoribe and @tkimura4 I am reopening this PR. |
Codecov ReportBase: 10.41% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 10.41% 10.41% -0.01%
==========================================
Files 1170 1170
Lines 83574 83574
Branches 19581 19581
==========================================
- Hits 8705 8704 -1
Misses 65364 65364
- Partials 9505 9506 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@TakaHoribe @tkimura4 Could you approve if this PR is okay for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1.0 (autowarefoundation#2057) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Maxime CLEMENT [email protected]
Description
This PR increases the value of the
max_lateral_accel
parameter in themotion_velocity_smoother
node. allowing to drive at higher velocities in curves.The current value of
0.8
m/s² is very conservative to avoid situations where the ego vehicle would drive too fast when close to some obstacles (e.g., guard rail) in curves. This PR changes the value to1.0
m/s².A new node (#1579) can be used to limit the velocity when driving near obstacles.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.