Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(motion_velocity_smoother): change max_lateral_accel from 0.8 to 1.0 #650

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Dec 23, 2022

Signed-off-by: tomoya.kimura [email protected]

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#2057

Description

Same change as autowarefoundation/autoware.universe#2057

This PR increases the value of the max_lateral_accel parameter in the motion_velocity_smoother node. allowing to drive at higher velocities in curves.
The current value of 0.8 m/s² is very conservative to avoid situations where the ego vehicle would drive too fast when close to some obstacles (e.g., guard rail) in curves. This PR changes the value to 1.0 m/s².

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 166f153 into awf-latest Dec 23, 2022
@tkimura4 tkimura4 deleted the feat-max-lat-accel-1.0 branch December 23, 2022 02:23
kosuke55 added a commit that referenced this pull request Dec 24, 2022
kosuke55 added a commit that referenced this pull request Dec 27, 2022
kosuke55 added a commit that referenced this pull request Jan 6, 2023
soblin pushed a commit that referenced this pull request Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants