-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): ignore pull over goal near lane start #2667
feat(behavior_path_planner): ignore pull over goal near lane start #2667
Conversation
Signed-off-by: kosuke55 <[email protected]>
Codecov ReportBase: 11.38% // Head: 11.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
==========================================
- Coverage 11.38% 11.36% -0.03%
==========================================
Files 1277 1277
Lines 89230 89427 +197
Branches 23619 23746 +127
==========================================
+ Hits 10160 10161 +1
- Misses 68297 68474 +177
- Partials 10773 10792 +19
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
808a5b3
to
0a3586d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#2667) feat(behavior_path_planner) ignore pull over goal near lane start Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
* feat(behavior_path_planner): ignore pull over goal near lane start (autowarefoundation#2667) feat(behavior_path_planner) ignore pull over goal near lane start Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> * feat(behavior_path_planner): add option for combining arc pull out paths (autowarefoundation#2669) * feat(behavior_path_planner): add option for combining arc pull out paths Signed-off-by: kosuke55 <[email protected]> * divide_pull_out_path Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]>
…utowarefoundation#2667) feat(behavior_path_planner) ignore pull over goal near lane start Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 [email protected]
Description
When the goal is set near lane start, the path is generated close to the drivable area edge. This causes distortion by obstacle_avoidacne_planner.
_014._.20kmph-2023-01-16_14.20.26.mp4
In this PR, ignore the goal candidates near the start of pull over target lanes to fix that.
Related links
launcher
tier iv internal link
Tests performed
psim
ignore_distance_from_lane_start: 10.0
pull_over_ignore_goal_near_lane_start-2023-01-17_14.48.07.mp4
ignore_distance_from_lane_start: 15.0
ignore_distance_from_lane_start: 20.0
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.