fix(behavior_path_planner): pull_over checks lane departure only for parking part #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
…parking part Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
fix/pull_over_lane_departure
branch
from
10d1b0e
to
9b57d61
Compare
7 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 17, 2023
…parking part (autowarefoundation#2673) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jan 30, 2023
…parking part (autowarefoundation#2673) Signed-off-by: kosuke55 <[email protected]> Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kosuke55 [email protected]
Description
The lane departure checker in shift_pull_over uses shifted_path, which causes a departure at the beginning of the lane
In this PR, only the parking part (start-end) is checked.
Related links
Tests performed
psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.