Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gnss/imu localizer #2848

Closed
wants to merge 163 commits into from
Closed

feat: add gnss/imu localizer #2848

wants to merge 163 commits into from

Conversation

rsasaki0109
Copy link
Member

@rsasaki0109 rsasaki0109 commented Feb 8, 2023

Description

This is the PR for integrating GNSS/IMU localizar discussed in the discussion below.
https://github.com/orgs/autowarefoundation/discussions/3257

  • Added gnss imu localizar related launch,param
  • Added localization_modepose_estimator_mode(lidar, gnss),eaglye_twisttwist_estimator_mode(gyro_odom_fusion, gyro_odom_gnss_fusion) parameter in localization.launch.xml to switch between pose,twist
  • In gyro_odom_gnss_fusion mode, twist is corrected by gnss.
  • You can adjust the eagleye pose output in launch/tier4_localization_launch/launch/eagleye/fix2pose.xml.

Related links

autowarefoundation/autoware#3261
autowarefoundation/autoware_launch#200
autowarefoundation/autoware-documentation#334

Tests performed

Localizaiton methods are expected to work as normal, even if they change.
Sample rosbag is available for simple operation tests.
Also, if you have a rosbag of a system with the same configuration of sensors, you can check the operation to some extent.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) labels Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.27 ⚠️

Comparison is base (0056a2a) 11.93% compared to head (fded6ce) 11.67%.

❗ Current head fded6ce differs from pull request most recent head aeb32ce. Consider uploading reports for the commit aeb32ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   11.93%   11.67%   -0.27%     
==========================================
  Files        1326     1321       -5     
  Lines       92209    90949    -1260     
  Branches    24649    24013     -636     
==========================================
- Hits        11008    10621     -387     
+ Misses      69788    69181     -607     
+ Partials    11413    11147     -266     
Flag Coverage Δ *Carryforward flag
differential 2.84% <ø> (?)
total 11.68% <ø> (-0.26%) ⬇️ Carriedforward from ba6a71d

*This pull request uses carry forward flags. Click here to find out more.

see 295 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsasaki0109 rsasaki0109 changed the title Feat/add gnss imu localizar feat(gnss localization): add gnss/imu localizar Feb 9, 2023
@rsasaki0109 rsasaki0109 marked this pull request as ready for review February 9, 2023 09:22
@xmfcx xmfcx changed the title feat(gnss localization): add gnss/imu localizar feat: add gnss/imu localizer Feb 9, 2023
@rsasaki0109
Copy link
Member Author

rsasaki0109 commented Feb 9, 2023

@yukkysaito
Corrected based on today's review.
048ef6b
I have reverted the pose_twist_fusion_filter.launch.xml and made the corresponding edits.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! First, I have some comments on the parameters that are introduced in this PR.

KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: kenji-miyake <[email protected]>
@github-actions github-actions bot added type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Mar 11, 2023
@rsasaki0109
Copy link
Member Author

rsasaki0109 commented Mar 13, 2023

The commits went wrong, should I close this PR and submit a different one...?
It appears that this repository will never be the same again.

status
All commits from the day I submitted the PR to now are being re-committed with the assumption that I have signed off on all commits.

@KYabuuchi
Copy link
Contributor

@rsasaki0109 I don't know the exact rules, but this PR with similar mistakes has been closed and re-created.

@rsasaki0109 rsasaki0109 mentioned this pull request Mar 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Cancelled
Development

Successfully merging this pull request may close these issues.