-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pose_initilizer): support gnss/imu pose estimator #2904
feat(pose_initilizer): support gnss/imu pose estimator #2904
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
- Coverage 11.99% 11.80% -0.20%
==========================================
Files 1314 1315 +1
Lines 91445 90718 -727
Branches 24240 24180 -60
==========================================
- Hits 10971 10709 -262
+ Misses 69113 68831 -282
+ Partials 11361 11178 -183
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This implementation was not adopted due to cyclomatic complexity |
@YamatoAndo |
localization/pose_initializer/src/pose_initializer/ndt_localization_trigger_module.cpp
Outdated
Show resolved
Hide resolved
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
localization/pose_initializer/src/pose_initializer/ndt_localization_trigger_module.cpp
Outdated
Show resolved
Hide resolved
localization/pose_initializer/src/pose_initializer/ekf_localization_trigger_module.cpp
Outdated
Show resolved
Hide resolved
@rsasaki0109 |
Just conforming to localization_trigger_module.cpp, no deeper meaning. I think your suggestion is good and I will modify it. |
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
…ation_trigger_module.cpp Co-authored-by: Takagi, Isamu <[email protected]> Signed-off-by: Ryohei Sasaki <[email protected]>
…ation_trigger_module.cpp Co-authored-by: Takagi, Isamu <[email protected]> Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
Sorry, this was a comment on the new file. Existing files will retain their original publication year. So please don't change |
Signed-off-by: Ryohei Sasaki <[email protected]>
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
localization/pose_initializer/src/pose_initializer/pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YamatoAndo @KeisukeShima |
Signed-off-by: Ryohei Sasaki <[email protected]>
Signed-off-by: Ryohei Sasaki <[email protected]>
@YamatoAndo @isamu-takagi |
…ation#2904) * Support GNSS/IMU pose estimator Signed-off-by: Ryohei Sasaki <[email protected]> * style(pre-commit): autofix Signed-off-by: Ryohei Sasaki <[email protected]> * Revert gnss/imu support Signed-off-by: Ryohei Sasaki <[email protected]> * Support GNSS/IMU pose estimator Signed-off-by: Ryohei Sasaki <[email protected]> * style(pre-commit): autofix Signed-off-by: Ryohei Sasaki <[email protected]> * Separate EKF and NDT trigger modules Signed-off-by: Ryohei Sasaki <[email protected]> * Integrate activate and deactivate into sendRequest Signed-off-by: Ryohei Sasaki <[email protected]> * style(pre-commit): autofix Signed-off-by: Ryohei Sasaki <[email protected]> * Change sendRequest function arguments Signed-off-by: Ryohei Sasaki <[email protected]> * style(pre-commit): autofix Signed-off-by: Ryohei Sasaki <[email protected]> * Remove unused conditional branches Signed-off-by: Ryohei Sasaki <[email protected]> * Fix command name Signed-off-by: Ryohei Sasaki <[email protected]> * Change to snake_case Signed-off-by: Ryohei Sasaki <[email protected]> * Fix typos Signed-off-by: Ryohei Sasaki <[email protected]> * Update localization/pose_initializer/src/pose_initializer/ekf_localization_trigger_module.cpp Co-authored-by: Takagi, Isamu <[email protected]> Signed-off-by: Ryohei Sasaki <[email protected]> * Update localization/pose_initializer/src/pose_initializer/ndt_localization_trigger_module.cpp Co-authored-by: Takagi, Isamu <[email protected]> Signed-off-by: Ryohei Sasaki <[email protected]> * Update copyright year Signed-off-by: Ryohei Sasaki <[email protected]> * Set the copyright year of ekf_localization_module to 2022 Signed-off-by: Ryohei Sasaki <[email protected]> * Delete unnecessary conditional branches Signed-off-by: Ryohei Sasaki <[email protected]> * Add ekf_enabled parameter Signed-off-by: Ryohei Sasaki <[email protected]> * Add #include <string> Signed-off-by: Ryohei Sasaki <[email protected]> --------- Signed-off-by: Ryohei Sasaki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ryohei Sasaki <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]>
Description
This is a modification of
pose_initilizer
to use GNSS/IMU pose estimtator.When parameter
ndt_enabled
istrue
,NdtLocalizationTriggerModule
.When parameter
ekf_enabled
istrue
,EkfLocalizationTriggerModule
.Related discussions are here.
#2848 (comment)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.