Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controllers): fix build error #3178

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 27, 2023

Description

Fixed the build error by the recent change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 27, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 27, 2023 06:56
@takayuki5168 takayuki5168 requested review from TakaHoribe and a team as code owners March 27, 2023 06:56
@takayuki5168
Copy link
Contributor Author

@TakaHoribe Could you review the PR.

@takayuki5168 takayuki5168 enabled auto-merge (squash) March 27, 2023 07:04
@takayuki5168 takayuki5168 changed the title fix(mpc_lateral_controller): fix build error fix(controllers): fix build error Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d4708ce) 12.21% compared to head (f654f2f) 12.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   12.21%   12.21%   -0.01%     
==========================================
  Files        1352     1352              
  Lines       94313    94312       -1     
  Branches    26776    26776              
==========================================
- Hits        11517    11516       -1     
  Misses      70636    70636              
  Partials    12160    12160              
Flag Coverage Δ *Carryforward flag
differential 47.40% <100.00%> (?)
total 12.20% <ø> (-0.01%) ⬇️ Carriedforward from d4708ce

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...dinal_controller/longitudinal_controller_utils.hpp 35.00% <ø> (ø)
...l_controller/src/longitudinal_controller_utils.cpp 83.33% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 48.44% <100.00%> (ø)
control/mpc_lateral_controller/src/mpc_utils.cpp 56.13% <100.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 276f0f7 into autowarefoundation:main Mar 27, 2023
@takayuki5168 takayuki5168 deleted the fix/lat-controller-build-error branch March 27, 2023 07:40
swiftfile pushed a commit to swiftfile/autoware.universe that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants