Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(avoidance): remove hard code params #3624

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 4, 2023

Description

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 4, 2023
@satoshi-ota satoshi-ota force-pushed the refactor/remove-hard-code-params branch from 03ba30a to 1c25db3 Compare May 4, 2023 09:23
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (debd8ca) 13.70% compared to head (6c2daee) 13.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
- Coverage   13.70%   13.62%   -0.08%     
==========================================
  Files        1397     1399       +2     
  Lines       98252   100631    +2379     
  Branches    29254    30959    +1705     
==========================================
+ Hits        13464    13712     +248     
- Misses      70235    71983    +1748     
- Partials    14553    14936     +383     
Flag Coverage Δ *Carryforward flag
differential 12.83% <0.00%> (?)
total 13.70% <ø> (+<0.01%) ⬆️ Carriedforward from 1c25db3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 24.41% <0.00%> (+4.49%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 4.23% <0.00%> (+0.81%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit ccdcb5c into autowarefoundation:main May 8, 2023
@satoshi-ota satoshi-ota deleted the refactor/remove-hard-code-params branch May 8, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants