Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(avoidance): remove hard code params in shift line triming process #341

Merged
merged 1 commit into from
May 8, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 4, 2023

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

soblin pushed a commit to soblin/autoware_launch that referenced this pull request May 7, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review May 8, 2023 00:37
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) May 8, 2023 07:19
@satoshi-ota satoshi-ota merged commit 88aca85 into main May 8, 2023
@satoshi-ota satoshi-ota deleted the refactor/remove-hard-code-params branch May 8, 2023 07:32
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…oundation#332)

* chore: sync awf-latest (autowarefoundation#322)

style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync awf-latest (autowarefoundation#325)

* chore: sync files (autowarefoundation#311)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: disable namespace `lane_start_bound` (autowarefoundation#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (autowarefoundation#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* rename

Signed-off-by: Kenji Miyake <[email protected]>

* refactor(vehicle_cmd_gate): add namespace (autowarefoundation#316)

Signed-off-by: Takamasa Horibe <[email protected]>

* style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

* chore(behavior_velocity): update latest params (autowarefoundation#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (autowarefoundation#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (autowarefoundation#305)

* add rtc controller

Signed-off-by: tkhmy <[email protected]>

* change line

Signed-off-by: tkhmy <[email protected]>

* change back to alphabetical order

Signed-off-by: tkhmy <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>

* add calibration status launcher to external_api_adaptor

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* pull awf-latest

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* chore: sync awf-latest (autowarefoundation#334)

* chore: sync files (autowarefoundation#327)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* refactor: virtual wall rviz config (autowarefoundation#326)

Signed-off-by: Takamasa Horibe <[email protected]>

* feat(rviz_plugin): adaptive scaling for display size (autowarefoundation#329)

Signed-off-by: Takamasa Horibe <[email protected]>

* fix: support context dict key for humble (autowarefoundation#328)

* fix: support context dict key for humble

Signed-off-by: wep21 <[email protected]>

* add todo comment

Co-authored-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* fix: modify type of global parameter (autowarefoundation#333)

Signed-off-by: wep21 <[email protected]>

* chore: sync files (autowarefoundation#335)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: use multithread for traffic light container as default (autowarefoundation#336)

Signed-off-by: tomoya.kimura <[email protected]>

* fix(localization_launch): fix input topic name (autowarefoundation#338)

* feat(behavior_velocity): add run out module (autowarefoundation#339)

* feat(behavior_velocity): add parameter yaml for behavior_velocity_planner

Signed-off-by: Tomohito Ando <[email protected]>

* feat(behavior_velocity): add run out module

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(mission_planner): disable lane_start_bound in Rviz (autowarefoundation#341)

Signed-off-by: h-ohta <[email protected]>

* pull the latest tier4/universe

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* pull awf-latest

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* fixed unnecessary change.

Signed-off-by: TakumiKozaka-T4 <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…arefoundation#402)

* chore: sync awf-latest (autowarefoundation#322)

style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync awf-latest (autowarefoundation#325)

* chore: sync files (autowarefoundation#311)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: disable namespace `lane_start_bound` (autowarefoundation#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (autowarefoundation#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* rename

Signed-off-by: Kenji Miyake <[email protected]>

* refactor(vehicle_cmd_gate): add namespace (autowarefoundation#316)

Signed-off-by: Takamasa Horibe <[email protected]>

* style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

* chore(behavior_velocity): update latest params (autowarefoundation#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (autowarefoundation#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (autowarefoundation#305)

* add rtc controller

Signed-off-by: tkhmy <[email protected]>

* change line

Signed-off-by: tkhmy <[email protected]>

* change back to alphabetical order

Signed-off-by: tkhmy <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>

* chore: sync awf-latest (autowarefoundation#334)

* chore: sync files (autowarefoundation#327)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* refactor: virtual wall rviz config (autowarefoundation#326)

Signed-off-by: Takamasa Horibe <[email protected]>

* feat(rviz_plugin): adaptive scaling for display size (autowarefoundation#329)

Signed-off-by: Takamasa Horibe <[email protected]>

* fix: support context dict key for humble (autowarefoundation#328)

* fix: support context dict key for humble

Signed-off-by: wep21 <[email protected]>

* add todo comment

Co-authored-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* fix: modify type of global parameter (autowarefoundation#333)

Signed-off-by: wep21 <[email protected]>

* chore: sync files (autowarefoundation#335)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: use multithread for traffic light container as default (autowarefoundation#336)

Signed-off-by: tomoya.kimura <[email protected]>

* fix(localization_launch): fix input topic name (autowarefoundation#338)

* feat(behavior_velocity): add run out module (autowarefoundation#339)

* feat(behavior_velocity): add parameter yaml for behavior_velocity_planner

Signed-off-by: Tomohito Ando <[email protected]>

* feat(behavior_velocity): add run out module

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(mission_planner): disable lane_start_bound in Rviz (autowarefoundation#341)

Signed-off-by: h-ohta <[email protected]>

* fix(stop_line): add ros_parameter (autowarefoundation#347)

* fix(stop_line): add ros_parameter

Signed-off-by: k-obitsu <[email protected]>

* fix(perception_launch): fix vehicle param in perception launch

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: k-obitsu <[email protected]>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
* chore: sync awf-latest (autowarefoundation#322)

style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync awf-latest (autowarefoundation#325)

* chore: sync files (autowarefoundation#311)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: disable namespace `lane_start_bound` (autowarefoundation#314)

* feat: disable lane_bound

* fix: lane_start_bound

* feat: add center_line_arrows to disable

* ci: add sync-awf.yaml (autowarefoundation#318)

* ci: add sync-awf.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* rename

Signed-off-by: Kenji Miyake <[email protected]>

* refactor(vehicle_cmd_gate): add namespace (autowarefoundation#316)

Signed-off-by: Takamasa Horibe <[email protected]>

* style: fix flake8 C417 (autowarefoundation#321)

Signed-off-by: Kenji Miyake <[email protected]>

* chore(behavior_velocity): update latest params (autowarefoundation#320)

* chore(behavior_velocity): update latest params

Signed-off-by: tanaka3 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(pre-commit): autoupdate (autowarefoundation#324)

updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(autoware_api_launch): add rtc controller (autowarefoundation#305)

* add rtc controller

Signed-off-by: tkhmy <[email protected]>

* change line

Signed-off-by: tkhmy <[email protected]>

* change back to alphabetical order

Signed-off-by: tkhmy <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>

* chore: sync awf-latest (autowarefoundation#334)

* chore: sync files (autowarefoundation#327)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* refactor: virtual wall rviz config (autowarefoundation#326)

Signed-off-by: Takamasa Horibe <[email protected]>

* feat(rviz_plugin): adaptive scaling for display size (autowarefoundation#329)

Signed-off-by: Takamasa Horibe <[email protected]>

* fix: support context dict key for humble (autowarefoundation#328)

* fix: support context dict key for humble

Signed-off-by: wep21 <[email protected]>

* add todo comment

Co-authored-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* fix: modify type of global parameter (autowarefoundation#333)

Signed-off-by: wep21 <[email protected]>

* chore: sync files (autowarefoundation#335)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: use multithread for traffic light container as default (autowarefoundation#336)

Signed-off-by: tomoya.kimura <[email protected]>

* fix(localization_launch): fix input topic name (autowarefoundation#338)

* feat(behavior_velocity): add run out module (autowarefoundation#339)

* feat(behavior_velocity): add parameter yaml for behavior_velocity_planner

Signed-off-by: Tomohito Ando <[email protected]>

* feat(behavior_velocity): add run out module

Signed-off-by: Tomohito Ando <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(mission_planner): disable lane_start_bound in Rviz (autowarefoundation#341)

Signed-off-by: h-ohta <[email protected]>

* fix(stop_line): add ros_parameter (autowarefoundation#347)

* fix(stop_line): add ros_parameter

Signed-off-by: k-obitsu <[email protected]>

* add localization score relay node

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* pull awf-latest

Signed-off-by: TakumiKozaka-T4 <[email protected]>

Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kah Hooi Tan <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Tomohito ANDO <[email protected]>
Co-authored-by: k-obitsu <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Mar 25, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants