Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix bad dynamic drivable area expansion at path extremities #4259

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 12, 2023

Description

This PR improves the dynamic drivable area expansion, making the bounds look cleaner, especially at the at the start and end of the path.

Before After
dynDA_before dynDA_after

Tests performed

Psim
Evaluator: https://evaluation.tier4.jp/evaluation/reports/tables/new?project_id=x2_dev&job_id=727d6936-d9ae-5829-98ec-a0f489b09ba9&catalog_id=6888286a-35b1-4121-b322-0c6f0e3d8868&filter=&table_config=date

Effects on system behavior

This should not impact the system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 27.35% and no project coverage change.

Comparison is base (8ff2128) 14.82% compared to head (10cd778) 14.82%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4259   +/-   ##
=======================================
  Coverage   14.82%   14.82%           
=======================================
  Files        1531     1531           
  Lines      105756   105814   +58     
  Branches    32145    32190   +45     
=======================================
+ Hits        15676    15689   +13     
- Misses      72961    72984   +23     
- Partials    17119    17141   +22     
Flag Coverage Δ *Carryforward flag
differential 13.11% <27.35%> (?)
total 14.80% <ø> (-0.02%) ⬇️ Carriedforward from 8ff2128

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 7.93% <0.00%> (-0.40%) ⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 6.86% <0.00%> (-0.22%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 6.56% <0.00%> (ø)
...path_planner/test/test_drivable_area_expansion.cpp 32.74% <0.00%> (-0.39%) ⬇️
.../scenario_selector_node/scenario_selector_node.cpp 46.04% <ø> (-0.39%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.17% <9.09%> (+0.08%) ⬆️
...rivable_area_expansion/drivable_area_expansion.cpp 36.93% <29.68%> (-13.07%) ⬇️
...er/src/utils/drivable_area_expansion/expansion.cpp 34.67% <52.94%> (+2.56%) ⬆️
...r/src/utils/drivable_area_expansion/footprints.cpp 37.50% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem force-pushed the fix/dyn_da_exp-cleaner_expansion branch from b46df4d to 76e475c Compare July 24, 2023 07:40
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jul 24, 2023
@maxime-clem maxime-clem force-pushed the fix/dyn_da_exp-cleaner_expansion branch 3 times, most recently from eada8b6 to b0afaaf Compare July 26, 2023 03:13
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jul 26, 2023
@maxime-clem maxime-clem marked this pull request as ready for review July 26, 2023 05:33
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2023
@maxime-clem maxime-clem force-pushed the fix/dyn_da_exp-cleaner_expansion branch from 928522a to f02e81f Compare July 28, 2023 07:22
@maxime-clem maxime-clem force-pushed the fix/dyn_da_exp-cleaner_expansion branch from f02e81f to f43c16a Compare August 7, 2023 04:19
@TakaHoribe
Copy link
Contributor

I'm in review

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem force-pushed the fix/dyn_da_exp-cleaner_expansion branch from 6a9193c to 10cd778 Compare August 10, 2023 05:47
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it works as expected.

especially at the at the start and end of the path.

Before:
image

After:
image

@maxime-clem maxime-clem merged commit 7159965 into autowarefoundation:main Aug 10, 2023
20 of 23 checks passed
@maxime-clem maxime-clem deleted the fix/dyn_da_exp-cleaner_expansion branch August 10, 2023 07:17
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 10, 2023
mkuri pushed a commit to tier4/autoware.universe that referenced this pull request Aug 10, 2023
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Aug 11, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants