-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(system_monitor): extend command line to display #4553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ito-san <[email protected]>
ito-san
added
type:new-feature
New functionalities or additions, feature requests.
component:system
System design and integration. (auto-assigned)
labels
Aug 8, 2023
LGTM. |
asana17
approved these changes
Aug 16, 2023
ito-san
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 16, 2023
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…on#4553) Signed-off-by: ito-san <[email protected]>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 21, 2023
…on#4553) Signed-off-by: ito-san <[email protected]>
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 25, 2023
…on#4553) Signed-off-by: ito-san <[email protected]>
Merged
7 tasks
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 28, 2023
…efoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 15, 2023
…on#4553) Signed-off-by: ito-san <[email protected]>
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…foundation#4553)" This reverts commit 3bf4673.
7 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 3, 2023
…on#4553) Signed-off-by: ito-san <[email protected]>
7 tasks
asa-naki
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 14, 2024
…efoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]>
asa-naki
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 29, 2024
* feat(system_error_monitor): manual modules (#793) * feat(rviz_plugin): console meter is too large on the Rviz with FHD display, isn't it? (#587) * feat(tier4_planning/vehicle_plugin): make plugins size scalable Signed-off-by: Takamasa Horibe <[email protected]> * remove space Signed-off-by: Takamasa Horibe <[email protected]> * scaling Signed-off-by: Takamasa Horibe <[email protected]> * change diag message Signed-off-by: asa-naki <[email protected]> * fix module name Signed-off-by: asa-naki <[email protected]> * add manual module and ignoring modules Signed-off-by: asa-naki <[email protected]> * Revert "feat(rviz_plugin): console meter is too large on the Rviz with FHD display, isn't it? (#587)" This reverts commit f96169c. * Revert "change diag message" This reverts commit dff01ce. * ci(pre-commit): autofix * fix spell check Signed-off-by: asa-naki <[email protected]> * Revert "fix spell check" This reverts commit 208aa1e. * Revert "fix module name" This reverts commit cec7653. * revert ignore module Signed-off-by: asa-naki <[email protected]> * current_mode check update Signed-off-by: asa-naki <[email protected]> * ci(pre-commit): autofix * delete margin Signed-off-by: asa-naki <[email protected]> --------- Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: asa-naki <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(ad_service_state_monitor): change configs name (#876) change configs name Signed-off-by: asa-naki <[email protected]> * feat(plannig_error_monitor): update error sharp angle threshold (#681) * fix error_sharp_angle Signed-off-by: Shigekazu Fukuta <[email protected]> * update readme Signed-off-by: Shigekazu Fukuta <[email protected]> --------- Signed-off-by: Shigekazu Fukuta <[email protected]> * fix: add error handling when path is invalid (#934) * fix(behavior_path): delete duplicated * add error handling * fix: when path size is 1 * fix(detection_area): search collision index only in lanelet (#695) * fix(detection_area): search collision index only in lanelet * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(detection_area): fix overline function (#930) * fix(detection_area): fix overline function * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(route_handler): fix threshold for removing overlapping points (#1015) * fix(route_handler): fix threshold for removing overlapping points * fix * fix(ntp_monitor): move chronyc command execution to a timer (backport autowarefoundation#4634) (#880) fix(ntp_monitor): move chronyc command execution to a timer (autowarefoundation#4634) * fix(ntp_monitor): move chronyc command execution to a timer * add newly added parameter timeout to config --------- Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]> * feat(elevation_map_loader): add error handling for std::runtime_error (backport autowarefoundation#4187) (#652) feat(elevation_map_loader): add error handling for std::runtime_error (autowarefoundation#4187) * feat(elevation_map_loader): Add error handling for std::runtime_error * feat(elevation_map_loader): add error message output --------- Signed-off-by: Shin-kyoto <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> * fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]> * fix(system_monitor): high-memory process are not provided in MEM order (backport autowarefoundation#4654) (#769) fix(system_monitor): high-memory process are not provided in MEM order (autowarefoundation#4654) * fix(process_monitor): high-memory process are not being provided in %MEM order * changed option from 'g' to 'n' --------- Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]> * fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995) * perf(system_monitor): fix program command line reading (autowarefoundation#5191) * Fix program command line reading Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * fix spelling commandline->command_line Signed-off-by: Owen-Liuyuxuan <[email protected]> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(system_monitor): output command line (autowarefoundation#5430) * fix(system_monitor): output command line Signed-off-by: takeshi.iwanari <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: Akihisa Nagata <[email protected]> * feat(imu_corrector): add gyro_bias_validator (backport autowarefoundation#4729) (#856) * feat(imu_corrector): add gyro_bias_validator (backport autowarefoundation#4729) * feat(imu_corrector): add gyro_bias_validator Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update Signed-off-by: kminoda <[email protected]> * revert launch Signed-off-by: kminoda <[email protected]> * updat Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * add debug publisher Signed-off-by: kminoda <[email protected]> * minor fix Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * add gtest Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * updat e readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * add diagnostics Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * validator -> estimator Signed-off-by: kminoda <[email protected]> * fix build Signed-off-by: kminoda <[email protected]> * update default parameter Signed-off-by: kminoda <[email protected]> * update comment Signed-off-by: kminoda <[email protected]> * update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * updated Signed-off-by: kminoda <[email protected]> * minor update in readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix pre-commit Signed-off-by: kminoda <[email protected]> * update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * Fix NG -> WARN Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: asa-naki <[email protected]> * build(imu_corrector): add missing diagnostic_updater dependency (autowarefoundation#4980) Signed-off-by: Esteve Fernandez <[email protected]> * add gyro_bias estimation in diag ( autowarefoundation#5054) Signed-off-by: asa-naki <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: asa-naki <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(imu_corrector): add gyro bias log (#918) add gyro_bias log Signed-off-by: asa-naki <[email protected]> * feat(system_error_monitor): add ignore_until_waiting_for_route module (#888) * add ignore_module Signed-off-by: asa-naki <[email protected]> * add description Signed-off-by: asa-naki <[email protected]> * ci(pre-commit): autofix * change name ignore_until_waiting_for_route Signed-off-by: asa-naki <[email protected]> * update description Signed-off-by: asa-naki <[email protected]> * rename function name and delete planning state Signed-off-by: asa-naki <[email protected]> * update description Signed-off-by: asa-naki <[email protected]> * Update --------- Signed-off-by: asa-naki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hiroki OTA <[email protected]> * feat(system_error_monitor): add ignore hartbeat timeout in initializing state (#972) * add ignore hartbeat timeout in initializing state Signed-off-by: asa-naki <[email protected]> * fix typo * Update comment * ci(pre-commit): autofix * fix typo * ci(pre-commit): autofix * update comment * ci(pre-commit): autofix --------- Signed-off-by: asa-naki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: asa-naki <[email protected]> Signed-off-by: Shigekazu Fukuta <[email protected]> Signed-off-by: ito-san <[email protected]> Signed-off-by: Shin-kyoto <[email protected]> Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shigekazu Fukuta <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: ito-san <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]>
asa-naki
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 17, 2024
…efoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]>
asa-naki
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 18, 2024
* fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768) fix(system_monitor): extend command line to display (autowarefoundation#4553) Signed-off-by: ito-san <[email protected]> Co-authored-by: ito-san <[email protected]> * feat(behavior_path_planner): resample output path (backport #1604) (#782) feat(behavior_path_planner): resample output path (#1604) * feat(behavior_path_planner): resample output path * update param Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> * ci: add dispatch-push-event workflow (#803) * ci: add dispatch-push-event workflow Signed-off-by: Keisuke Shima <[email protected]> * fix: change APP KEY Signed-off-by: Keisuke Shima <[email protected]> * chore: use strategy Signed-off-by: Keisuke Shima <[email protected]> * chore: change trigger Signed-off-by: Keisuke Shima <[email protected]> * pre-commit fixes Signed-off-by: Keisuke Shima <[email protected]> * Update .github/workflows/dispatch-push-event.yaml * Update .github/workflows/dispatch-push-event.yaml * style(pre-commit): autofix * Update .github/workflows/dispatch-push-event.yaml --------- Signed-off-by: Keisuke Shima <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909) * fix(behavior_path): only apply spline interpolate for output, not for turn_signal processing * fix implementation * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(behavior_path): fix base points vanishing and inconsistent lane_ids on the spline interpolated path (#929) * add base points to resampled path in behavior_path * Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)" This reverts commit c80c986. * ci(pre-commit): autofix * fix insert * fix: not interpolate behavior velocity path * Revert "Revert "fix(behavior_path): only apply spline interpolation for its output, not for turn_signal processing (#909)"" This reverts commit e6dd540. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995) * perf(system_monitor): fix program command line reading (autowarefoundation#5191) * Fix program command line reading Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * fix spelling commandline->command_line Signed-off-by: Owen-Liuyuxuan <[email protected]> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(system_monitor): output command line (autowarefoundation#5430) * fix(system_monitor): output command line Signed-off-by: takeshi.iwanari <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: Akihisa Nagata <[email protected]> * feat(obstacle_stop): upd obstacle hunting (#1068) * Adapted from PR #1458 Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR autowarefoundation#1627 Signed-off-by: Shigekazu Fukuta <[email protected]> * fix parameter name Signed-off-by: Shigekazu Fukuta <[email protected]> * Adapted from PR autowarefoundation#2647 Signed-off-by: Shigekazu Fukuta <[email protected]> * ci(pre-commit): autofix * fix build error * ci(pre-commit): autofix * remove comment line * remove logic * Delete parameters other than those added this time * ci(pre-commit): autofix * add stop vehicle check * ci(pre-commit): autofix * fix stop velocity threshold * fix engage obstacle clear and stop threshold * ci(pre-commit): autofix --------- Signed-off-by: Shigekazu Fukuta <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(obstacle_avoidance_planner): add empty check (#1285) * fix(obstacle_avoidance_planner): add empty check * ci(pre-commit): autofix * add invalid_argument * delete empty check * return code moved to end * add warning log * update rclcpp_debug * delete debug log * Delete unnecessary blank lines --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(virtual traffic light): suppress lauch (#1290) * suppress launch Signed-off-by: Yuki Takagi <[email protected]> * add existence check Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Shigekazu Fukuta <[email protected]> * revert: #929,#909,#782 * revert: #1068 - d56c191. --------- Signed-off-by: ito-san <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Keisuke Shima <[email protected]> Signed-off-by: Owen-Liuyuxuan <[email protected]> Signed-off-by: takeshi.iwanari <[email protected]> Signed-off-by: Shigekazu Fukuta <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: ito-san <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yuxuan Liu <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: takeshi-iwanari <[email protected]> Co-authored-by: Shigekazu Fukuta <[email protected]> Co-authored-by: Yuki TAKAGI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:system
System design and integration. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:new-feature
New functionalities or additions, feature requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The process_monitor provides information about processes that are utilizing high CPU and memory resources.
However, the displayed COMMAND field only shows the executable name such as
ros2
orpython3
, and identifying the process solely based on the provided COMMAND name is not easy.With this change, it's possible to provide a more detailed COMMAND string.
Related links
TIER IV INTERNAL LINK TO JIRA
Tests performed
ros2 run rqt_runtime_monitor rqt_runtime_monitor
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.