Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix geometric parallel parking lane ids #4603

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 12, 2023

Description

correct geometric parallel parking lane ids to fix wrong drivable area and path cut etc.

Related links

Tests performed

psim

image

image

image

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 12, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 12, 2023
@kosuke55
Copy link
Contributor Author

merge #4604 first

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08% 🎉

Comparison is base (9f22504) 14.82% compared to head (29d7a45) 14.90%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4603      +/-   ##
==========================================
+ Coverage   14.82%   14.90%   +0.08%     
==========================================
  Files        1531     1531              
  Lines      105766   106337     +571     
  Branches    32155    32560     +405     
==========================================
+ Hits        15680    15851     +171     
- Misses      72961    73282     +321     
- Partials    17125    17204      +79     
Flag Coverage Δ *Carryforward flag
differential 15.74% <0.00%> (?)
total 14.82% <ø> (+<0.01%) ⬆️ Carriedforward from c1dd226

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 4.00% <0.00%> (-0.10%) ⬇️
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 24.67% <0.00%> (-0.22%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 13, 2023
@kosuke55 kosuke55 merged commit 7f02d6a into main Aug 13, 2023
30 of 34 checks passed
@kosuke55 kosuke55 deleted the fix/geometric_pull_out branch August 13, 2023 10:02
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 14, 2023
…foundation#4603)

* fix(start_planner): fix geometric parallel parking lane ids

Signed-off-by: kosuke55 <[email protected]>

* fix stop path drivable lanes

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…foundation#4603)

* fix(start_planner): fix geometric parallel parking lane ids

Signed-off-by: kosuke55 <[email protected]>

* fix stop path drivable lanes

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 21, 2023
…foundation#4603)

* fix(start_planner): fix geometric parallel parking lane ids

Signed-off-by: kosuke55 <[email protected]>

* fix stop path drivable lanes

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…foundation#4603)

* fix(start_planner): fix geometric parallel parking lane ids

Signed-off-by: kosuke55 <[email protected]>

* fix stop path drivable lanes

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants