Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): avoidance shift line processing bug #4731

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 24, 2023

Description

🤖 Generated by Copilot at 09af845

This pull request enhances the avoidance_module of the behavior_path_planner by refining the shift line handling and fixing a RTC status bug. It also optimizes the memory usage of the path shifter by avoiding redundant operations.


It doesn't remove shift lines correctly during yield status. As a result avoidance path usually chatters unexpectedly.

simplescreenrecorder-2023-08-24_18.23.56.mp4

Tests performed

simplescreenrecorder-2023-08-24_17.05.14.mp4

Effects on system behavior

Improve avoidance performance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 24, 2023
@satoshi-ota satoshi-ota changed the title fix(avoidance): safety check chattering fix(avoidance): avoidance shift line processing bug Aug 24, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf42588) 15.10% compared to head (09af845) 15.10%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4731   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1563     1563           
  Lines      107888   107891    +3     
  Branches    33101    33106    +5     
=======================================
+ Hits        16300    16301    +1     
- Misses      73819    73820    +1     
- Partials    17769    17770    +1     
Flag Coverage Δ *Carryforward flag
differential 13.18% <0.00%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from cf42588

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <0.00%> (-0.13%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.63% <0.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!
(I will apply new interface for side_shift module...

@satoshi-ota satoshi-ota merged commit b5e2c13 into autowarefoundation:main Aug 25, 2023
55 of 57 checks passed
@satoshi-ota satoshi-ota deleted the feat/chattering-prevention branch August 25, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants