-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): avoidance shift line processing bug #4731
fix(avoidance): avoidance shift line processing bug #4731
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4731 +/- ##
=======================================
Coverage 15.10% 15.10%
=======================================
Files 1563 1563
Lines 107888 107891 +3
Branches 33101 33106 +5
=======================================
+ Hits 16300 16301 +1
- Misses 73819 73820 +1
- Partials 17769 17770 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you!
(I will apply new interface for side_shift module...
Description
🤖 Generated by Copilot at 09af845
This pull request enhances the
avoidance_module
of thebehavior_path_planner
by refining the shift line handling and fixing a RTC status bug. It also optimizes the memory usage of the path shifter by avoiding redundant operations.It doesn't remove shift lines correctly during yield status. As a result avoidance path usually chatters unexpectedly.
simplescreenrecorder-2023-08-24_18.23.56.mp4
Tests performed
simplescreenrecorder-2023-08-24_17.05.14.mp4
Effects on system behavior
Improve avoidance performance
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.