Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add processOnEntry in start_planner #4953

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Sep 12, 2023

Description

🤖 Generated by Copilot at 6dc7005

The pull request improves the safety check logic and code readability for the GoalPlannerModule and StartPlannerModule classes in the behavior path planner. It adds new functions to initialize the safety check parameters on entry, fixes some bugs, and removes some redundant or misplaced code. It also adds comments and TODOs to the header files.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 12, 2023
@kyoichi-sugahara kyoichi-sugahara force-pushed the feature/add_processOnEntry_start_planner branch from 6dc7005 to 9565135 Compare September 12, 2023 02:19
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara force-pushed the feature/add_processOnEntry_start_planner branch from 9565135 to f269697 Compare September 12, 2023 02:20
@kyoichi-sugahara kyoichi-sugahara changed the title feature(behavior_path_planner): add processOnEntry in start_planner feat(behavior_path_planner): add processOnEntry in start_planner Sep 12, 2023
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.13% 🎉

Comparison is base (82006db) 15.80% compared to head (f434e0c) 15.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4953      +/-   ##
==========================================
+ Coverage   15.80%   15.94%   +0.13%     
==========================================
  Files        1580     1580              
  Lines      109179   109189      +10     
  Branches    33646    33649       +3     
==========================================
+ Hits        17258    17405     +147     
+ Misses      73313    73149     -164     
- Partials    18608    18635      +27     
Flag Coverage Δ *Carryforward flag
differential 17.82% <84.61%> (?)
total 15.90% <ø> (+0.09%) ⬆️ Carriedforward from f269697

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 13.33% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 18.18% <ø> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 15.76% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 9.07% <76.92%> (+1.47%) ⬆️
...cene_module/start_planner/start_planner_module.cpp 37.26% <92.30%> (+7.69%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) September 12, 2023 05:36
@kyoichi-sugahara kyoichi-sugahara merged commit 57b1ef1 into autowarefoundation:main Sep 12, 2023
22 of 23 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feature/add_processOnEntry_start_planner branch September 12, 2023 07:56
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…owarefoundation#4953)

* add process on entry in start_planner

Signed-off-by: kyoichi-sugahara <[email protected]>

* delete description

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 18, 2023
…owarefoundation#4953)

* add process on entry in start_planner

Signed-off-by: kyoichi-sugahara <[email protected]>

* delete description

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
…owarefoundation#4953)

* add process on entry in start_planner

Signed-off-by: kyoichi-sugahara <[email protected]>

* delete description

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants