-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): add processOnEntry in start_planner #4953
Merged
kyoichi-sugahara
merged 4 commits into
autowarefoundation:main
from
kyoichi-sugahara:feature/add_processOnEntry_start_planner
Sep 12, 2023
Merged
feat(behavior_path_planner): add processOnEntry in start_planner #4953
kyoichi-sugahara
merged 4 commits into
autowarefoundation:main
from
kyoichi-sugahara:feature/add_processOnEntry_start_planner
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
September 12, 2023 02:18
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 12, 2023
kyoichi-sugahara
force-pushed
the
feature/add_processOnEntry_start_planner
branch
from
September 12, 2023 02:19
6dc7005
to
9565135
Compare
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
feature/add_processOnEntry_start_planner
branch
from
September 12, 2023 02:20
9565135
to
f269697
Compare
kyoichi-sugahara
changed the title
feature(behavior_path_planner): add processOnEntry in start_planner
feat(behavior_path_planner): add processOnEntry in start_planner
Sep 12, 2023
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 12, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4953 +/- ##
==========================================
+ Coverage 15.80% 15.94% +0.13%
==========================================
Files 1580 1580
Lines 109179 109189 +10
Branches 33646 33649 +3
==========================================
+ Hits 17258 17405 +147
+ Misses 73313 73149 -164
- Partials 18608 18635 +27
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
approved these changes
Sep 12, 2023
kyoichi-sugahara
merged commit Sep 12, 2023
57b1ef1
into
autowarefoundation:main
22 of 23 checks passed
kyoichi-sugahara
deleted the
feature/add_processOnEntry_start_planner
branch
September 12, 2023 07:56
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…owarefoundation#4953) * add process on entry in start_planner Signed-off-by: kyoichi-sugahara <[email protected]> * delete description Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 18, 2023
…owarefoundation#4953) * add process on entry in start_planner Signed-off-by: kyoichi-sugahara <[email protected]> * delete description Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
4 tasks
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…owarefoundation#4953) * add process on entry in start_planner Signed-off-by: kyoichi-sugahara <[email protected]> * delete description Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 6dc7005
The pull request improves the safety check logic and code readability for the
GoalPlannerModule
andStartPlannerModule
classes in the behavior path planner. It adds new functions to initialize the safety check parameters on entry, fixes some bugs, and removes some redundant or misplaced code. It also adds comments and TODOs to the header files.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.