Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avoidance): exit if there is no avoidable object #5051

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(avoidance): exit if there is no avoidable object #5051

merged 1 commit into from
Sep 21, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 20, 2023 •
edited
Loading

Description

🤖 Generated by Copilot at 4d856c7

Improve avoidance module logic for non-avoidable objects. Change the avoidance_module.cpp file to modify the state transition and velocity planning based on the object attributes.

Tests performed

Effects on system behavior

Avoidance module finishes properly.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 20, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review September 20, 2023 22:51
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.14% 🎉

Comparison is base (33463ce) 15.80% compared to head (4d856c7) 15.94%.
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5051      +/-   ##
==========================================
+ Coverage   15.80%   15.94%   +0.14%     
==========================================
  Files        1583     1583              
  Lines      109822   110950    +1128     
  Branches    34377    35214     +837     
==========================================
+ Hits        17352    17694     +342     
- Misses      73362    73943     +581     
- Partials    19108    19313     +205
Flag Coverage Δ *Carryforward flag
differential 17.59% <0.00%> (?)
total 15.80% <ø> (ø) Carriedforward from 33463ce

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 12.42% <0.00%> (-0.02%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyoichi-sugahara
kyoichi-sugahara approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit 326868b into autowarefoundation:main Sep 21, 2023
47 of 50 checks passed
@satoshi-ota satoshi-ota deleted the fix/exit-unavoidable branch September 21, 2023 00:47
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2023
@satoshi-ota @kyoichi-sugahara
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
e4e8219 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2023
@satoshi-ota @kyoichi-sugahara
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
e5c730e 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2023
@satoshi-ota @kyoichi-sugahara
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
ccfea63 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2023
@satoshi-ota @kosuke55
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
a432014 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2023
@satoshi-ota @kosuke55
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
f77980c 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@kosuke55 kosuke55 mentioned this pull request Sep 24, 2023
Merged
7 tasks
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2023
@kosuke55 @satoshi-ota
feat(avoidance): imporove avoidance near goal (#863)
e70187f 
* feat(avoidance): add parameter to configurate avoidance return point (autowarefoundation#4467)

Signed-off-by: satoshi-ota <[email protected]>

* fix(utils): improve monotonic bound generation logic (autowarefoundation#4706)

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): insert return dead line point (autowarefoundation#5029)

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): exit if there is no avoidable object (autowarefoundation#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 26, 2023
Merged
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Oct 10, 2023
@satoshi-ota
fix(avoidance): exit if there is no avoidable object (autowarefoundat…
aaa7281 
…ion#5051)

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota mentioned this pull request Oct 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@rej55 rej55 Awaiting requested review from rej55

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees

@kosuke55 kosuke55

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshi-ota @kyoichi-sugahara @kosuke55