-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): improve monotonic bound generation logic #4706
fix(utils): improve monotonic bound generation logic #4706
Conversation
Signed-off-by: satoshi-ota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
avoidance_goal_planner-2023-08-24_22.38.21.mp4
…on#4706 Signed-off-by: kosuke55 <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4706 +/- ##
==========================================
- Coverage 14.88% 14.87% -0.02%
==========================================
Files 1549 1549
Lines 106958 109050 +2092
Branches 32791 34359 +1568
==========================================
+ Hits 15925 16216 +291
- Misses 73639 75087 +1448
- Partials 17394 17747 +353
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…on#4706 Signed-off-by: kosuke55 <[email protected]>
…ion#4706) Signed-off-by: satoshi-ota <[email protected]>
* feat(avoidance): add parameter to configurate avoidance return point (autowarefoundation#4467) Signed-off-by: satoshi-ota <[email protected]> * fix(utils): improve monotonic bound generation logic (autowarefoundation#4706) Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): insert return dead line point (autowarefoundation#5029) Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): exit if there is no avoidable object (autowarefoundation#5051) Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: Satoshi OTA <[email protected]>
Description
🤖 Generated by Copilot at 2a25c40
Fix a bug in
makeBoundLongitudinallyMonotonic
that caused incorrect bound orientation for the last path point. This improves the behavior planning accuracy forbehavior_path_planner
.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.