Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): improve monotonic bound generation logic #4706

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 22, 2023

Description

🤖 Generated by Copilot at 2a25c40

Fix a bug in makeBoundLongitudinallyMonotonic that caused incorrect bound orientation for the last path point. This improves the behavior planning accuracy for behavior_path_planner.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 22, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review August 22, 2023 08:15
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

avoidance_goal_planner-2023-08-24_22.38.21.mp4

kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 24, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (9b1e4e3) 14.88% compared to head (2a25c40) 14.87%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
- Coverage   14.88%   14.87%   -0.02%     
==========================================
  Files        1549     1549              
  Lines      106958   109050    +2092     
  Branches    32791    34359    +1568     
==========================================
+ Hits        15925    16216     +291     
- Misses      73639    75087    +1448     
- Partials    17394    17747     +353     
Flag Coverage Δ *Carryforward flag
differential 13.18% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from 9b1e4e3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 17.26% <0.00%> (+1.89%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 59c7eda into autowarefoundation:main Aug 24, 2023
37 of 41 checks passed
@satoshi-ota satoshi-ota deleted the fix/monotonic-bound branch August 24, 2023 22:43
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2023
* feat(avoidance): add parameter to configurate avoidance return point (autowarefoundation#4467)

Signed-off-by: satoshi-ota <[email protected]>

* fix(utils): improve monotonic bound generation logic (autowarefoundation#4706)

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): insert return dead line point (autowarefoundation#5029)

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): exit if there is no avoidable object (autowarefoundation#5051)

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants