fix(lane_change): do not use reference values of polygon outer #5318
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Oct 16, 2023 in 37s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method normal.cpp: NormalLaneChange::filterObject 🔥
Annotations
Check notice on line 1 in planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1341 to 1342, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 841 in planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
NormalLaneChange::filterObject already has high cyclomatic complexity, and now it increases in Lines of Code from 97 to 98. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading