Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): keep stopping until all shift lines are registered #5658

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 23, 2023

Description

🤖[deprecated] Generated by Copilot at abf7691

This pull request adds a feature to the AvoidanceModule that allows the vehicle to request approval from the RTC for the avoidance maneuver based on a configurable policy. The policy can be set to either shift_line or maneuver in the avoidance.param.yaml file.

Please reveiw following PR at first:
autowarefoundation/autoware_launch#699


Previously, avoidance module made rtc requests for each shift line. Then, operator had to approve several times to avoid object and return original lane during driving.

In this PR, I added new option in order to execute avoidance maneuver by only once approval manupulation. If the parameter policy.approval is set to maneuver, the module makes requests per avoidance maneuver (avoid + return).

      policy:
        # policy for rtc request. select "shift_line" or "maneuver".
        # "shift_line": request approval for each shift line.
        # "maneuver": request approval for avoidance maneuver (avoid + return).
        approval: "shift_line"

policy.approval: shift_line

simplescreenrecorder-2023-11-24_09.02.53.mp4

policy.approval: maneuver

simplescreenrecorder-2023-11-24_09.05.38.mp4

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 23, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review November 24, 2023 00:10
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 1376 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (f4f47b8) 10.29%.
Report is 128 commits behind head on main.

Files Patch % Lines
...anner/src/utils/avoidance/shift_line_generator.cpp 13.19% 435 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.58% 168 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.48% 111 Missing and 17 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.56% 63 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.47% 54 Missing ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 28 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 24.24% 0 Missing and 25 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
... and 25 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5658       +/-   ##
===========================================
- Coverage   15.32%   10.29%    -5.03%     
===========================================
  Files        1721       84     -1637     
  Lines      118559    11403   -107156     
  Branches    37995     6397    -31598     
===========================================
- Hits        18169     1174    -16995     
+ Misses      79657     7985    -71672     
+ Partials    20733     2244    -18489     
Flag Coverage Δ
differential 10.29% <9.65%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) December 1, 2023 12:24
@satoshi-ota satoshi-ota merged commit 3e4706e into autowarefoundation:main Dec 1, 2023
24 of 28 checks passed
@satoshi-ota satoshi-ota deleted the feat/keep-stop-policy branch December 11, 2023 05:21
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants