-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): add calculation of obstacle distance to ego #6057
Conversation
@isouf Thanks for the PR. We welcome your contribution, and the code changes in the PR look good. With apologies for the insufficient guidance, we would like to ask you to work on the following two points.
|
…o ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
@yuki-takagi-66 thank you very much for your message. I signed off the commit message as per your request. I tried to add the |
@yuki-takagi-66 also tried to add using |
@isouf Thank you for your kind response. I asked the administrator about the CI check, and the current operation is that the reviewer starts the CI check. I apologize for requesting the wrong task. I have just set it up. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
==========================================
- Coverage 14.67% 14.67% -0.01%
==========================================
Files 1858 1858
Lines 126598 126600 +2
Branches 37149 37150 +1
==========================================
Hits 18582 18582
- Misses 87129 87131 +2
Partials 20887 20887
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. looks good to me
f78ea59
into
autowarefoundation:main
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> Signed-off-by: karishma <[email protected]>
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
… abandon to stop (#1336) * feat(obstacle_cruise_planner): add calculation of obstacle distance to ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> * refactor(obstacle_cruise): refactor a function checkConsistency() (autowarefoundation#7105) refactor Signed-off-by: Yuki Takagi <[email protected]> * add abandon function Signed-off-by: Yuki Takagi <[email protected]> * fix lib include Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Ioannis Souflas <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Ioannis Souflas <[email protected]>
Add the arc length from the ego to the obstacle stop point to the stop_reasons topic.
Description
Tests performed
Tested the behaviour manually using the Planning Simulator.
Effects on system behavior
This PR adds the required functionality (arc length calculation) to populate the
dist_to_stop_pose
field of the StopFactor.msg message.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.