feat(obstacle_cruise_planner): add calculation of obstacle distance to ego #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isouf
requested review from
kosuke55,
satoshi-ota,
takayuki5168 and
yuki-takagi-66
as code owners
github-actions
bot
added
the
component:planning
yuki-takagi-66
added
tag:run-build-and-test-differential
|
@isouf Thanks for the PR. We welcome your contribution, and the code changes in the PR look good. With apologies for the insufficient guidance, we would like to ask you to work on the following two points.
|
…o ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
|
@yuki-takagi-66 thank you very much for your message. I signed off the commit message as per your request. I tried to add the
|
|
@yuki-takagi-66 also tried to add using |
yuki-takagi-66
added
the
tag:run-build-and-test-differential
|
@isouf Thank you for your kind response. I asked the administrator about the CI check, and the current operation is that the reviewer starts the CI check. I apologize for requesting the wrong task. I have just set it up. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
==========================================
- Coverage 14.67% 14.67% -0.01%
==========================================
Files 1858 1858
Lines 126598 126600 +2
Branches 37149 37150 +1
==========================================
Hits 18582 18582
- Misses 87129 87131 +2
Partials 20887 20887
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yuki-takagi-66
approved these changes
Jan 16, 2024
yuki-takagi-66
merged commit f78ea59
into
autowarefoundation:main
28 of 33 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
yuki-takagi-66
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 5, 2024
…o ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 14, 2024
… abandon to stop (#1336) * feat(obstacle_cruise_planner): add calculation of obstacle distance to ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> * refactor(obstacle_cruise): refactor a function checkConsistency() (autowarefoundation#7105) refactor Signed-off-by: Yuki Takagi <[email protected]> * add abandon function Signed-off-by: Yuki Takagi <[email protected]> * fix lib include Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Ioannis Souflas <[email protected]> Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Ioannis Souflas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the arc length from the ego to the obstacle stop point to the stop_reasons topic.
Description
Tests performed
Tested the behaviour manually using the Planning Simulator.
Effects on system behavior
This PR adds the required functionality (arc length calculation) to populate the
dist_to_stop_posefield of the StopFactor.msg message.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.