Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise)!: type specified stop deccel limit and enabling abandon to stop #1336

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Jun 14, 2024

Description

https://tier4.atlassian.net/browse/RT1-6542 への対応PRです。
値についての検討はほとんどおこなっていないです。

Related links

ブランチ名都合での https://github.com/tier4/autoware.universe/pull/1323の作成し直しPRです。

Tests performed

psimが起動して自動走行ができることまでは確認しました。

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

isouf and others added 4 commits June 5, 2024 11:44
…o ego (autowarefoundation#6057)

Add the arc length from the ego to the obstacle stop point to the stop_reasons topic.

Signed-off-by: Ioannis Souflas <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 changed the title Rt1 6542 feat(obstacle_cruise)!: type specified stop deccel limit and enabling abandon to stop Jun 14, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review June 14, 2024 07:02
Copy link

@saka1-s saka1-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saka1-s saka1-s merged commit d8826bb into beta/v0.19.1 Jun 14, 2024
16 of 20 checks passed
@saka1-s saka1-s deleted the RT1-6542 branch June 14, 2024 07:08
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants