Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scan_ground_filter): change launch option and threshold #670

Merged
merged 3 commits into from
Apr 14, 2022
Merged

feat(scan_ground_filter): change launch option and threshold #670

merged 3 commits into from
Apr 14, 2022

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Apr 11, 2022 •
edited
Loading

Description

Change launch option and threshold to suppress false positives.

Related links

#643

Tests performed

Run obstacle segmentation with sample rosbag to verify that there are no false positives on the ground surface.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #670 (c6d2ab3) into main (151ee70) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   10.59%   10.59%           
=======================================
  Files         735      734    -1     
  Lines       51761    51756    -5     
  Branches     6596     6596           
=======================================
  Hits         5482     5482           
+ Misses      41819    41814    -5     
  Partials     4460     4460
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.60% <0.00%> (+0.01%) ⬆️ Carriedforward from 8d74732

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nd_segmentation/src/scan_ground_filter_nodelet.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 25.00% <ø> (ø)
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 16.78% <0.00%> (ø)
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 9.67% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac209b...c6d2ab3. Read the comment docs.

@miursh miursh changed the title feat(scan_ground_filter): feat(scan_ground_filter): change launch option and threshold Apr 12, 2022
13304490790 pushed a commit to 13304490790/autoware.universe that referenced this pull request Apr 12, 2022
@taikitanaka3 @TakaHoribe
@maxime-clem @niosus @kokosabu @tkimura4 @rej55 @takayuki5168 @mkuri @KeisukeShima
feat: trajectory follower package (autowarefoundation#84)
eb47ec5 
* Back port .auto control packages (autowarefoundation#571)

* Implement Lateral and Longitudinal Control Muxer

* [autowarefoundation#570] Porting wf_simulator

* [autowarefoundation#1189] Deactivate flaky test in 'trajectory_follower_nodes'

* [autowarefoundation#1189] Fix flacky test in 'trajectory_follower_nodes/latlon_muxer'

* [autowarefoundation#1057] Add osqp_interface package

* [autowarefoundation#1057] Add library code for MPC-based lateral control

* [autowarefoundation#1271] Use std::abs instead of abs

* [autowarefoundation#1057] Implement Lateral Controller for Cargo ODD

* [autowarefoundation#1246] Resolve "Test case names currently use snake_case but should be CamelCase"

* [autowarefoundation#1325] Deactivate flaky smoke test in 'trajectory_follower_nodes'

* [autowarefoundation#1058] Add library code of longitudinal controller

* Fix build error for trajectory follower

Signed-off-by: wep21 <[email protected]>

* Fix build error for trajectory follower nodes

Signed-off-by: wep21 <[email protected]>

* [autowarefoundation#1272] Add AckermannControlCommand support to simple_planning_simulator

* [autowarefoundation#1058] Add Longitudinal Controller node

* [autowarefoundation#1058] Rename velocity_controller -> longitudinal_controller

* [autowarefoundation#1058] Update CMakeLists.txt for the longitudinal_controller_node

* [autowarefoundation#1058] Add smoke test python launch file

* [autowarefoundation#1058] Use LowPassFilter1d from trajectory_follower

* [autowarefoundation#1058] Use autoware_auto_msgs

* [autowarefoundation#1058] Changes for .auto (debug msg tmp fix, common func, tf listener)

* [autowarefoundation#1058] Remove unused parameters

* [autowarefoundation#1058] Fix ros test

* [autowarefoundation#1058] Rm default params from declare_parameters + use autoware types

* [autowarefoundation#1058] Use default param file to setup NodeOptions in the ros test

* [autowarefoundation#1058] Fix docstring

* [autowarefoundation#1058] Replace receiving a Twist with a VehicleKinematicState

* [autowarefoundation#1058] Change class variables format to m_ prefix

* [autowarefoundation#1058] Fix plugin name of LongitudinalController in CMakeLists.txt

* [autowarefoundation#1058] Fix copyright dates

* [autowarefoundation#1058] Reorder includes

* [autowarefoundation#1058] Add some tests (~89% coverage without disabling flaky tests)

* [autowarefoundation#1058] Add more tests (90+% coverage without disabling flaky tests)

* [autowarefoundation#1058] Use Float32MultiArrayDiagnostic message for debug and slope

* [autowarefoundation#1058] Calculate wheel_base value from vehicle parameters

* [autowarefoundation#1058] Cleanup redundant logger setting in tests

* [autowarefoundation#1058] Set ROS_DOMAIN_ID when running tests to prevent CI failures

* [autowarefoundation#1058] Remove TF listener and use published vehicle state instead

* [autowarefoundation#1058] Change smoke tests to use autoware_testing

* [autowarefoundation#1058] Add plotjuggler cfg for both lateral and longitudinal control

* [autowarefoundation#1058] Improve design documents

* [autowarefoundation#1058] Disable flaky test

* [autowarefoundation#1058] Properly transform vehicle state in longitudinal node

* [autowarefoundation#1058] Fix TF buffer of lateral controller

* [autowarefoundation#1058] Tuning of lateral controller for LGSVL

* [autowarefoundation#1058] Fix formating

* [autowarefoundation#1058] Fix /tf_static sub to be transient_local

* [autowarefoundation#1058] Fix yaw recalculation of reverse trajs in the lateral controller

* modify trajectory_follower for galactic build

Signed-off-by: Takamasa Horibe <[email protected]>

* [autowarefoundation#1379] Update trajectory_follower

* [autowarefoundation#1379] Update simple_planning_simulator

* [autowarefoundation#1379] Update trajectory_follower_nodes

* apply trajectory msg modification in control

Signed-off-by: Takamasa Horibe <[email protected]>

* move directory

Signed-off-by: Takamasa Horibe <[email protected]>

* remote control/trajectory_follower level dorectpry

Signed-off-by: Takamasa Horibe <[email protected]>

* remove .iv trajectory follower

Signed-off-by: Takamasa Horibe <[email protected]>

* use .auto trajectory_follower

Signed-off-by: Takamasa Horibe <[email protected]>

* remove .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <[email protected]>

* use .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <[email protected]>

* add tmp_autoware_auto_dependencies

Signed-off-by: Takamasa Horibe <[email protected]>

* tmporally add autoware_auto_msgs

Signed-off-by: Takamasa Horibe <[email protected]>

* apply .auto message split

Signed-off-by: Takamasa Horibe <[email protected]>

* fix build depend

Signed-off-by: Takamasa Horibe <[email protected]>

* fix packages using osqp

* fix autoware_auto_geometry

* ignore lint of some packages

* ignore ament_lint of some packages

* ignore lint/pre-commit of trajectory_follower_nodes

* disable unit tests of some packages

Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: Igor Bogoslavskyi <[email protected]>
Co-authored-by: MIURA Yasuyuki <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: tomoya.kimura <[email protected]>
Signed-off-by: tanaka3 <[email protected]>

* Fix message interface and tests of 'trajectory_follower_nodes' (autowarefoundation#617)

* Update longitudinal_controller_node to use VehicleOdometry

* Update lateral_controller_node for VehicleOdometry and SteeringReport

* Fix tests

Signed-off-by: tanaka3 <[email protected]>

* Change the topic name of the control_cmd to align them in trajectory_follower_node (autowarefoundation#659)

* Fix topic names

* Fix namespace

* Fix test codes

Signed-off-by: tanaka3 <[email protected]>

* Fix type of current odometry in trajectory_follower_node (autowarefoundation#666)

Signed-off-by: tanaka3 <[email protected]>

* [latlon muxer] fix gtest (autowarefoundation#670)

* fix gtest

* remove unchanged

Signed-off-by: tanaka3 <[email protected]>

* Update lateral controller (autowarefoundation#708)

* Fix parameter names of mpc_follower (autowarefoundation#1376)

* remove yaw_recalc param in mpc (autowarefoundation#1241) (autowarefoundation#1476)

* parameterize curvature num (autowarefoundation#1674) (autowarefoundation#1577)

* fix rosparam steer_rate_lim_degs to steer_rate_lim_dps in mpc_follower (autowarefoundation#1848)

* Fix spellcheck fail for some packages autowarefoundation#1842

* use interpolation::slerp (autowarefoundation#2161)

* Fix/mpc reset prev result (autowarefoundation#2185)

* add add guard (autowarefoundation#2184)

* add-mpc-optimization-status-print (autowarefoundation#2189)

* Apply ament_uncrustify

* Update control/trajectory_follower/src/qp_solver/qp_solver_osqp.cpp

Co-authored-by: Takamasa Horibe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Signed-off-by: tanaka3 <[email protected]>

* Use vehicle info utils (autowarefoundation#709)

* Use vehicle info utils and disable unit test

* Update trajectory_follower_nodes default parameters and reenable tests

* Separate vehicle info param file for test

Co-authored-by: Maxime CLEMENT <[email protected]>
Signed-off-by: tanaka3 <[email protected]>

* remove stop distance condition from stopState decision (autowarefoundation#1916) (autowarefoundation#715)

Signed-off-by: tanaka3 <[email protected]>

* velocity_controller sync to .iv develop latest (autowarefoundation#699)

* non extrapolate velocity in lerpTrajectory to avoid negative velocity just before vehicle stops (autowarefoundation#2033)

* Add keep braking function at driving state (autowarefoundation#2346)

* Add keep braking function at driving state

Signed-off-by: Makoto Kurihara <[email protected]>

* Remove debug messages

Signed-off-by: Makoto Kurihara <[email protected]>

* Fix format

Signed-off-by: Makoto Kurihara <[email protected]>

* Feature/add doc for keep braking function at driving state (autowarefoundation#2366)

* Add the description of brake keeping

Signed-off-by: Makoto Kurihara <[email protected]>

* Add the english document

Signed-off-by: Makoto Kurihara <[email protected]>

* Improve description

Signed-off-by: Makoto Kurihara <[email protected]>

* Add english description

Signed-off-by: Makoto Kurihara <[email protected]>

Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Signed-off-by: tanaka3 <[email protected]>

* fix topic name in plot juggler (autowarefoundation#734)

Signed-off-by: tanaka3 <[email protected]>

* Fix unstable test in trajectory_follower_nodes (autowarefoundation#731)

* Added spin_some to store tf_buffer

* add more spin

* uncomment statement

* Remove temp file

* Update control/trajectory_follower_nodes/src/lateral_controller_node.cpp

Co-authored-by: Takamasa Horibe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Signed-off-by: tanaka3 <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: Igor Bogoslavskyi <[email protected]>
Co-authored-by: MIURA Yasuyuki <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: tomoya.kimura <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
@miursh miursh marked this pull request as ready for review April 13, 2022 06:15
badai-nguyen
badai-nguyen approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit f68121e into autowarefoundation:main Apr 14, 2022
@miursh miursh deleted the fix/segmentation_for_small_noise branch April 14, 2022 10:39
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 15, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@miursh @pre-commit-ci @boyali
feat(scan_ground_filter): change launch option and threshold (tier4#670)
5997bdc 
* Add care for near but high points

Signed-off-by: Shunsuke Miura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@miursh @pre-commit-ci @boyali
feat(scan_ground_filter): change launch option and threshold (tier4#670)
716d8bd 
* Add care for near but high points

Signed-off-by: Shunsuke Miura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@miursh @pre-commit-ci @boyali
feat(scan_ground_filter): change launch option and threshold (tier4#670)
0ff4d98 
* Add care for near but high points

Signed-off-by: Shunsuke Miura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@miursh @pre-commit-ci @boyali
feat(scan_ground_filter): change launch option and threshold (tier4#670)
6aed5f2 
* Add care for near but high points

Signed-off-by: Shunsuke Miura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Jul 26, 2023
@tier4-autoware-public-bot
Merge pull request autowarefoundation#670 from tier4/sync-upstream
6d31ad7 
chore: sync upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badai-nguyen badai-nguyen badai-nguyen approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miursh @badai-nguyen